chore: update default Node.js from 22 to 24#2373
Conversation
|
@KEGustafsson please feel free to commit into this PR. |
6c92117 to
cbde01f
Compare
What do you mean with Windows x86? |
|
Can you remove build pipelines from here, so PR is split to SK core changes and I'll do docker pipes separately. |
|
Windows x86 = outdated 32 bit windows As maintainer just push to this Repo/PR |
6f12fbc to
1c47c21
Compare
|
FYI With the switch to node 24 we will loose the support of the 32bit Victron Cerbo GX. node 22 is the final version for that device. |
|
We definitely can't stop supporting the Cerbo. Pretty large user base there. But this is only changing the recommended version, right? |
|
22 is LTS until April 2027. I don’t think there’s anything pressing us to explicitly push minimum version beyond that for some time. Naturally the whole software stack will continue to evolve, so a clock is ticking somewhere. Node-RED on Venus is in the same bind. |
|
Even npm package is build using Node v24 it can be installed to v22 fine. Mainly affecting to docker images which have node v24 bundled in it. Isn't Victron using npm packages, not docker images? |
|
Yes, nothing to do with docker images. |
1c47c21 to
d180d10
Compare
d180d10 to
6078e2d
Compare
Update minimum required version to >=22 and recommended to 24. Remove legacy Node 6 Array.includes check. Update CI workflows, tsconfig, documentation and breaking changes.
Workflow changes will be handled by the maintainer separately.
6078e2d to
97d40d2
Compare
Summary
.nvmrc,tsconfig.base.json(@tsconfig/node24), andpackage.jsonenginesArray.includesruntime check (proper semver check inversion.ts)Notes
@KEGustafsson please feel free to commit into this PR
release.yml,build-docker.ymlnpm build step) to use Node 24 out of scope