fix(security): make token expiration "NEVER" case-insensitive#2459
Merged
tkurki merged 1 commit intoSignalK:masterfrom Mar 19, 2026
Merged
fix(security): make token expiration "NEVER" case-insensitive#2459tkurki merged 1 commit intoSignalK:masterfrom
tkurki merged 1 commit intoSignalK:masterfrom
Conversation
tkurki
reviewed
Mar 19, 2026
Member
tkurki
left a comment
tkurki
left a comment
There was a problem hiding this comment.
Let's extract isNever(theExpiration and use that for consistency.
dirkwa
force-pushed
the
fix-never-case-sensitive
branch
from
86d9185 to
4ca32b7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
When approving device access requests, entering "never" (lowercase) in the Authentication Timeout field silently fails — the token gets created with a literal expiration string instead of being treated as non-expiring.
Extracts an
isNever()helper and uses it at all 5 expiration comparison sites intokensecurity.tsfor consistent, case-insensitive matching.Fixes #1739