fix(resources): return 404 for nonexistent resource ID#2462
Open
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Open
fix(resources): return 404 for nonexistent resource ID#2462dirkwa wants to merge 1 commit intoSignalK:masterfrom
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Conversation
getFromAll() returned {} when no provider had the requested resource,
making it impossible to distinguish a missing resource from a valid
empty one. Now throws so HTTP endpoints return 404 and the
programmatic API rejects the promise.
Fixes SignalK#1612
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
getResource()returned{}instead of an error when a resource ID didn't exist, making it impossible for callers to distinguish "not found" from a valid empty resource.The
getFromAll()helper usedPromise.allSettledand silently ignored all rejections, always returning the initial{}. Now throws when no provider returns data, so HTTP endpoints return 404 and the programmatic API (app.resourcesApi.getResource()) rejects the promise.Manually tested
GET /signalk/v2/api/resources/waypoints/nonexistent-id→ 404{"state":"FAILED","statusCode":404,"message":"Resource not found! (nonexistent-id)"}GET /signalk/v2/api/resources/waypoints/→ 200{}(empty collection, unaffected)Fixes #1612