fix(streams): set default TCP idle timeout to 60 seconds#2465
Open
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Open
fix(streams): set default TCP idle timeout to 60 seconds#2465dirkwa wants to merge 1 commit intoSignalK:masterfrom
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Conversation
TCP connections previously had no idle timeout unless explicitly configured, causing stale connections to go undetected. Default to 60 seconds so connections automatically reconnect when data stops flowing. Users can set 0 to explicitly disable the timeout.
dirkwa
force-pushed
the
fix-tcp-default-timeout
branch
from
3bf091e to
589754a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1562
Summary
TCP connections had no idle timeout unless explicitly configured, so stale connections went undetected and never reconnected. Defaults to 60 seconds. Users can still set a custom value or explicitly set 0 to disable.
Manually verified timeout parsing logic: