fix(settings): show correct mDNS status in admin UI#2466
Open
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Open
fix(settings): show correct mDNS status in admin UI#2466dirkwa wants to merge 1 commit intoSignalK:masterfrom
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Conversation
mDNS is on by default (only disabled when explicitly set to false), but the settings endpoint returned false when the setting was undefined, making the UI show "off" for a service that was running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1531
mDNS runs by default (only disabled when explicitly set to
false), but the settings GET endpoint usedapp.config.settings.mdns || false, which returnedfalsewhen the setting was never configured. This made the admin UI toggle show "Off" for a service that was actually running. Changed to use the sameisUndefined() ||pattern already used by other default-on settings likeaccessLogging.