fix(security): include timeToLive in login responses#2468
Open
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Open
fix(security): include timeToLive in login responses#2468dirkwa wants to merge 1 commit intoSignalK:masterfrom
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Conversation
The Signal K spec requires login responses to include timeToLive (token expiry in seconds) alongside the token. Both the REST (POST /login with JSON) and WebSocket login responses were missing this field.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1476
Summary
The Signal K specification requires login responses to include a
timeToLivefield indicating how long the token is valid, in seconds. The server was only returning thetokenfield.Adds
timeToLiveto both REST (/signalk/v1/auth/login) and WebSocket login responses. When the server's token expiration is set toNEVER, the field is omitted.Test
Tested manually against a server with security enabled (port 4000):
REST login:
Response includes
timeToLive(in seconds) alongsidetoken.WebSocket login:
Response includes
timeToLivein the login reply.NEVER expiration: With server configured for
NEVERtoken expiration, verifiedtimeToLiveis correctly omitted from the response.Duration calculations verified:
1h→3600,24h→86400,7d→604800.