fix(admin-ui): preserve enabled state when editing data connections#2511
Open
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Open
fix(admin-ui): preserve enabled state when editing data connections#2511dirkwa wants to merge 1 commit intoSignalK:masterfrom
dirkwa wants to merge 1 commit intoSignalK:masterfrom
Conversation
The providerClicked callback hardcoded enabled: true, overwriting the actual saved state. Clicking a disabled connection showed it as enabled in the edit dialog.
dirkwa
force-pushed
the
fix-connection-enabled-state
branch
from
e0c6284 to
1175057
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
enabled: trueinproviderClickedthat overwrote the actual saved state when opening a data connection for editingThe
structuredClone(provider)spread already carries the correctenabledvalue from the server. The hardcoded override was only appropriate for new connections (separate code path, unchanged).Manually tested