-
Notifications
You must be signed in to change notification settings - Fork 46.2k
fix(blocks): add YouTube Shorts URL support #11659
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
fix(blocks): add YouTube Shorts URL support #11659
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
|
Thank you for your PR to fix the Wikipedia API 403 errors and add support for YouTube Shorts URLs! The changes themselves look good, but there are a couple of things that need to be addressed before this can be merged:
Once the checklist is completely filled out and you've clarified the feature flag change, this PR should be ready for merging. |
…vitas#11639) ### Changes 🏗️ Chat should be disabled by default; otherwise, it flashes, and if Launch Darkly fails to fail, it is dangerous. ### Checklist 📋 #### For code changes: - [x] I have clearly listed my changes in the PR description - [x] I have made a test plan - [x] I have tested my changes according to the test plan: - [x] Run locally with Launch Darkly disabled and test the above
Added support for parsing YouTube Shorts URLs (youtube.com/shorts/...) in the TranscribeYoutubeVideoBlock to extract video IDs correctly. Includes test cases for YouTube Shorts URL extraction. Related to Significant-Gravitas#11500
5e78817 to
63e65d9
Compare
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
|
Thank you for your contribution to add YouTube Shorts URL support and fix the Wikipedia API issues. The code changes look good and the tests for YouTube Shorts URL extraction are helpful. Before we can merge this PR, please complete the test plan checklist in your PR description. All items need to be checked off. Currently, only the first item ("Added unit tests for YouTube Shorts URL extraction") is checked. Also, I notice your PR description mentions a Wikipedia API fix, but I don't see those changes in the provided diff. Could you please ensure all the changes described in your PR summary are included in the PR? Once the checklist is fully completed and all described changes are included, we can proceed with merging this PR. |
Summary
Added support for parsing YouTube Shorts URLs (
youtube.com/shorts/...) in the TranscribeYoutubeVideoBlock to extract video IDs correctly.Changes
_extract_video_idmethod inyoutube.pyto handle Shorts URL formatRelated Issue
Fixes #11500
Test Plan