Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(frontend): Remove unnecessary keywords in BaseAutoGPTServerAPI #8242

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

PRIYANKjakharia
Copy link

Background

fixed issue #8101

Changes 🏗️

the main change to the BaseAutoGPTServerAPI class was the removal of the async keyword from 23 methods that don't use await internally. These methods now return Promises directly, which is more efficient and cleaner. The async keyword was retained for 4 methods that do use await. No changes were made to private methods or WebSocket-related functions. These modifications address the issue of unnecessary async functions while maintaining the same functionality, improving code efficiency without altering the class's behavior.

@PRIYANKjakharia PRIYANKjakharia requested a review from a team as a code owner October 1, 2024 18:02
@PRIYANKjakharia PRIYANKjakharia requested review from Swiftyos and majdyz and removed request for a team October 1, 2024 18:02
@CLAassistant
Copy link

CLAassistant commented Oct 1, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
2 out of 3 committers have signed the CLA.

✅ Torantulino
✅ Pwuts
❌ PRIYANKjakharia
You have signed the CLA already but the status is still pending? Let us recheck it.

@github-actions github-actions bot added platform/frontend AutoGPT Platform - Front end platform/backend AutoGPT Platform - Back end labels Oct 1, 2024
@github-actions github-actions bot added the size/m label Oct 1, 2024
@Pwuts Pwuts changed the title Update baseClient.ts refactor(frontend): Remove unnecessary keywords in BaseAutoGPTServerAPI Oct 2, 2024
Copy link
Member

@Pwuts Pwuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me, thanks!

Just beware that - as a trivial refactoring PR - this really borders on "stuff that's not worth the effort to review", considering the development stage that we're in. We'd much rather have contributions to resolve one of the many unassigned issues.

Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform/backend AutoGPT Platform - Back end platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 2 size/m
Projects
Status: 👍🏼 Mergeable
Development

Successfully merging this pull request may close these issues.

4 participants