Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth docs updates based on google block changes #8243

Open
wants to merge 64 commits into
base: master
Choose a base branch
from
Open

OAuth docs updates based on google block changes #8243

wants to merge 64 commits into from

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented Oct 1, 2024 •
edited
Loading

Background

Google Auth added a few changes to the base providers that mean the docs and examples need updated. This is a tedious and potentially hazardous process that could be forgotten.

I also found that there were a few missing details for making your own provider that I overlooked due to building the _auth.py for google.

Changes 🏗️

  • configures snippets: a method of inserting code from our codebase into the docs
  • Swaps many examples to use snippets for auth
  • Adds updates that were made because of google auth changes to docs
  • Clarifies that types are required for the credential field in a block
  • Shows how to add the logos and auth required details to the frontend

Testing 🔍

Note

Only for the new autogpt platform, currently in autogpt_platform/

  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

ntindle and others added 30 commits September 30, 2024 18:45
@ntindle
feat(frontend,backend): testing
27c62a1
@ntindle
feat: testing
4293a70
@ntindle
feat(backend): it works for reading email
b4d2935
@ntindle
feat(backend): more docs on google
9e15497
@ntindle
fix(frontend,backend): formatting
f079983
@ntindle
feat(backend): more logigin (i know this should be debug)
59d8ccd
@ntindle
feat(backend): make real the default scopes
ac8e99b
@ntindle
feat(backend): tests and linting
95d6c28
@ntindle
fix: code review prep
fc6084c
@ntindle
feat: sheets block
59f0094
@ntindle
feat: liniting
5be1ce0
@ntindle
Update route.ts
81d1052
@ntindle @Pwuts
Update autogpt_platform/backend/backend/integrations/oauth/google.py
b01da5a 
Co-authored-by: Reinier van der Leer <[email protected]>
@ntindle @Pwuts
Update autogpt_platform/backend/backend/server/routers/integrations.py
25c5206 
Co-authored-by: Reinier van der Leer <[email protected]>
@ntindle
fix: revert opener change
392cf7a
@ntindle
feat(frontend): add back opener
fac9a53 
required to work on mac edge
@ntindle
feat(frontend): drop typing list import from gmail
b5dded0
@ntindle
fix: code review comments
56cabd9
@ntindle
feat: code review changes
b6f17dc
@ntindle
feat: code review changes
5ec1206
@ntindle
fix(backend): move from asserts to checks so they don't get optimized…
7491b6a 
… away in the future
@ntindle
fix(backend): code review changes
58324a7
@ntindle
fix(backend): remove google specific check
3ec0aa5
@ntindle
fix: add typing
9484a4e
@ntindle
fix: only enable google blocks when oauth is configured for google
af1ef1a
@ntindle
fix: errors are real and valid outputs always when output
65de432
@ntindle
fix(backend): add provider detail for debuging scope declines
2004d80
@ntindle @Pwuts
Update autogpt_platform/frontend/src/components/integrations/credenti…
3ebc7dd 
…als-input.tsx

Co-authored-by: Reinier van der Leer <[email protected]>
@ntindle
fix(frontend): enhance with comment, typeof error isn't known so this…
0da12a8 
… is best way to ensure the stringifyication will work
@ntindle
feat: code review change requests
d43c944
Base automatically changed from add-gmail to master October 3, 2024 16:36
@github-actions github-actions bot added the conflicts Automatically applied to PRs with merge conflicts label Oct 3, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 3, 2024

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

@github-actions github-actions bot added size/xl and removed size/l labels Oct 4, 2024
@github-actions github-actions bot removed the conflicts Automatically applied to PRs with merge conflicts label Oct 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

@github-actions github-actions bot added size/l and removed size/xl labels Oct 4, 2024
@ntindle ntindle requested a review from kcze October 5, 2024 00:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majdyz majdyz Awaiting requested review from majdyz majdyz is a code owner automatically assigned from Significant-Gravitas/maintainers

@Pwuts Pwuts Awaiting requested review from Pwuts

@kcze kcze Awaiting requested review from kcze

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation platform/backend AutoGPT Platform - Back end platform/blocks platform/frontend AutoGPT Platform - Front end Review effort [1-5]: 4 size/l
Projects
AutoGPT development kanban
Status: 🚧 Needs work
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ntindle @kcze