Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block execution status in case of error #8267

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vishesh10
Copy link
Contributor

User description

Background

This PR fixes the incorrect block execution status in case there is an error in execution.

Changes 🏗️

  • Updated the block.py file to raise exception in case an error is encountered during execution.

Test

  • Start block execution
Screenshot 2024-10-05 at 11 31 20 AM
  • The status now shows as "Failed" in case of error.

PR Quality Scorecard ✨

  • Have you used the PR description template?   +2 pts
  • Is your pull request atomic, focusing on a single change?   +5 pts
  • Have you linked the GitHub issue(s) that this PR addresses?   +5 pts
  • Have you documented your changes clearly and comprehensively?   +5 pts
  • Have you changed or added a feature?   -4 pts
    • Have you added/updated corresponding documentation?   +4 pts
    • Have you added/updated corresponding integration tests?   +5 pts
  • Have you changed the behavior of AutoGPT?   -5 pts
    • Have you also run agbenchmark to verify that these changes do not regress performance?   +10 pts

@vishesh10 vishesh10 requested a review from a team as a code owner October 5, 2024 06:12
@vishesh10 vishesh10 requested review from Torantulino and kcze and removed request for a team October 5, 2024 06:12
Copy link

PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here.

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪
🧪 No relevant tests
🔒 No security concerns identified
⚡ Recommended focus areas for review

Error Handling
The new code raises a ValueError when an error is encountered, but it might be better to raise a more specific exception type for better error handling and debugging.

Code Duplication
The new error handling code is similar to the existing error handling for invalid output data. Consider refactoring to reduce duplication.

@github-actions github-actions bot added platform/backend AutoGPT Platform - Back end size/s labels Oct 5, 2024
Copy link

netlify bot commented Oct 5, 2024

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 1cb7b62
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6700d8ba76e3610008762c7c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🆕 Needs initial review
Development

Successfully merging this pull request may close these issues.

When a block fails, it still shows as completed
1 participant