-
Notifications
You must be signed in to change notification settings - Fork 45.9k
feat(backend): Migrate old models in existing agents #9452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(backend): Migrate old models in existing agents #9452
Conversation
β Deploy Preview for auto-gpt-docs-dev canceled.
|
Here's the code health analysis summary for commits Analysis Summary
|
β Deploy Preview for auto-gpt-docs canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general happy with this approach. However, I don't feel we should be migrating ai models with clearly communicating it to the user.
Can we add a ticket to push a notification to the user when a model has to be migrated and we can address this at an appropriate time
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
Conflicts have been resolved! π A maintainer will review the pull request shortly. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
β¦existing-agents
Conflicts have been resolved! π A maintainer will review the pull request shortly. |
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
β¦existing-agents
Conflicts have been resolved! π A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Won't this get slower on every run? we will keep increasing the number of nodes we are checking
Though we've been doing it on other startup query so I guess it's fine π€·
#9452 was throwing `operator does not exist: text ? unknown` on deployed dev and so the function call was commented as a hotfix. This PR fixes and re-enables the llm model migration function. ### Changes ποΈ - Uncomment and fix `migrate_llm_models` function ### Checklist π #### For code changes: - [x] I have clearly listed my changes in the PR description - [x] I have made a test plan - [x] I have tested my changes according to the test plan: - [x] Migrate nodes with non-existing models - [x] Don't migrate nodes without any model or with correct models --------- Co-authored-by: Zamil Majdy <[email protected]>
Some existing nodes use models that no longer exist as values on
LlmModel
enum.Changes ποΈ
LlmModel
fields that do not exist inLlmModel
enum togpt-4o
, directly inAgentNode->constantInput
db column, on server startupChecklist π
For code changes:
gpt-4o
for all affectedAgentNode
s