-
Notifications
You must be signed in to change notification settings - Fork 45.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(settings): Rework user settings page with Form, loading skeleton… #9476
Merged
ntindle
merged 123 commits into
dev
from
andrewhooker2/secrt-1077-add-email-service-settings-page
Feb 19, 2025
Merged
feat(settings): Rework user settings page with Form, loading skeleton… #9476
ntindle
merged 123 commits into
dev
from
andrewhooker2/secrt-1077-add-email-service-settings-page
Feb 19, 2025
+764
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-compose' into ntindle/secrt-1087-attach-rabbit-mq-to-the-services-processes-similar-to-how
…-our-docker-compose
…r-compose' into ntindle/secrt-1087-attach-rabbit-mq-to-the-services-processes-similar-to-how
…rvices-processes-similar-to-how
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
…plates/agent_run.html.jinja2
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
ntindle
previously approved these changes
Feb 14, 2025
ntindle
previously approved these changes
Feb 14, 2025
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
ntindle
approved these changes
Feb 19, 2025
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
platform/backend
AutoGPT Platform - Back end
platform/frontend
AutoGPT Platform - Front end
Review effort [1-5]: 4
size/xl
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented a fully functional user settings page allowing changes to account details and notification preferences. This change uses a server first approach and adds much needed form validation to this page.
This PR has added loading skeletons for better UX during data fetching. Refactored related components to support these changes and finally implemented server actions to streamline data ingestion.
Note to developers:
At the moment the notification switches set back to default upon save. We will want to pass in this information after the api is implemented.
Changes 🏗️
Rebuilt / Refactored
SettingsFormInput
toSettingsForm
:Added
loading.tsx
Skeletons
we can deliver a better loading UI for our users causing less screen shifting.Added
actions.ts
There is an additional TODO for @ntindle for the api endpoint getting created. This endpoint will cover the newly added notification switches and it's toggles.
Screenshots 📷
Before Changes:
After Changes:
Form Validation
Checklist 📋
For code changes:
Test Plan
profile/settings
Save changes
button is disabled. Toggle a switch and notice theSave changes
button is now enabled.New Password
andConfirm New Password
input fields and selectSave changes
New password should be different from the old password