feat(backend): Agent Presets backend improvements #9786
+315
−198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dpoints) Frontend: - Add logic to fetch, select/view, and create presets to `/library/agents/[id]` - refactor: Brand `LibraryAgentPreset.id` + references Backend: - Add `graph_id` filter parameter to `GET /library/presets` (`list_presets`) endpoint
github-project-automation
bot
moved this to 🆕 Needs initial review
in AutoGPT development kanban
github-actions
bot
added
platform/frontend
✅ Deploy Preview for auto-gpt-docs-dev canceled.
|
5 tasks
|
Here's the code health analysis summary for commits Analysis Summary
|
✅ Deploy Preview for auto-gpt-docs canceled.
|
github-merge-queue bot
pushed a commit
that referenced
this pull request
Apr 10, 2025
Distilled from #9541 to reduce the scope of that PR. - Part of #9307 - ❗ Blocks #9786 - ❗ Blocks #9541 ### Changes 🏗️ - Fix `LibraryAgent` schema (for #9786) - Fix relationships between `LibraryAgent`, `AgentGraph`, and `AgentPreset` - Impose uniqueness constraint on `LibraryAgent` - Rename things that are called `agent` that actually refer to a `graph`/`agentGraph` - Fix singular/plural forms in DB schema - Simplify reference names of closely related objects (e.g. `AgentGraph.AgentGraphExecutions` -> `AgentGraph.Executions`) - Eliminate use of `# type: ignore` in DB statements - Add `typed` and `typed_cast` utilities to `backend.util.type` ### Checklist 📋 #### For code changes: - [x] I have clearly listed my changes in the PR description - [x] I have made a test plan - [x] I have tested my changes according to the test plan: - [x] CI static type checking (with all risky `# type: ignore` removed) - [x] Check that column references in views are updated
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
Pwuts
requested review from
Swiftyos and
aarushik93
and removed request for
a team
Pwuts
changed the title
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
github-actions
bot
removed
the
conflicts
|
Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly. |
kcze
approved these changes
Apr 11, 2025
| @@ -232,7 +234,7 @@ async def create_library_agent( | |||
| isCreatedByUser=(user_id == graph.user_id), | |||
| useGraphIsActiveVersion=True, | |||
| User={"connect": {"id": user_id}}, | |||
| # Creator={"connect": {"id": agent.userId}}, | |||
| # Creator={"connect": {"id": graph.user_id}}, | |||
There was a problem hiding this comment.
Not sure, it was like that when I found it
There was a problem hiding this comment.
Can we annotate and find out the context?
github-project-automation
bot
moved this from 🆕 Needs initial review
to 👍🏼 Mergeable
in AutoGPT development kanban
github-actions
bot
added
the
conflicts
|
This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request. |
majdyz
reviewed
Apr 21, 2025
| @@ -113,7 +126,12 @@ async def create_preset( | |||
| HTTPException: If an error occurs while creating the preset. | |||
| """ | |||
| try: | |||
| return await db.upsert_preset(user_id, preset) | |||
| if isinstance(preset, models.LibraryAgentPresetCreatable): | |||
| return await db.create_preset(user_id, preset) | |||
There was a problem hiding this comment.
This pattern is not neat. We've been catching exceptions through middleware, we can just generally return 404 on any not found exception error that way rather than spamming try catch in all of our endpoint code, similarly with 500.
majdyz
approved these changes
Apr 21, 2025
|
Let me know when you have resolved the conflicts so I can reapprove |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of Implement Agent Presets functionality #9307
❗ Blocks feat(platform): Agent Presets UX #9541
Changes 🏗️
Backend:
Fix+improve
GET /library/presets(list_presets) endpointgraph_idfilter parameterAllow partial preset updates:
PUT /presets/{preset_id}->PATCH /presets/{preset_id}Allow creating preset from graph execution through
POST /presetsClean up models & DB functions
upsert_presetintocreate_preset+update_presetLibraryAgentPresetUpdatableCreateLibraryAgentPresetRequestwithLibraryAgentPresetCreatableLibraryAgentPresetCreatableas base class forLibraryAgentPresetset_is_deleted_for_library_agent(..)Frontend:
LibraryAgentPreset.id+ referencesChecklist 📋
For code changes: