Skip to content

feat(blocks): initial google calendar #9920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 12, 2025
Merged

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented May 7, 2025

We want to add support for reading + writing events for google calendar so agents can do cool stuff with that!

Changes πŸ—οΈ

  • Add support for google calendar blocks

Checklist πŸ“‹

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Run manual tests of each block
    • Build and run automatic tests

@ntindle ntindle requested a review from a team as a code owner May 7, 2025 18:24
@ntindle ntindle requested review from Swiftyos and aarushik93 and removed request for a team May 7, 2025 18:24
@github-project-automation github-project-automation bot moved this to πŸ†• Needs initial review in AutoGPT development kanban May 7, 2025
Copy link

netlify bot commented May 7, 2025

βœ… Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
πŸ”¨ Latest commit 971aab2
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/6821c080306d840008f65f3e

Copy link

qodo-merge-pro bot commented May 7, 2025

PR Reviewer Guide πŸ”

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 πŸ”΅πŸ”΅πŸ”΅βšͺβšͺ
πŸ§ͺΒ No relevant tests
πŸ”’Β Security concerns

OAuth token handling:
The code is handling sensitive OAuth tokens and credentials. While the implementation uses Secret types for tokens, there's no validation that the tokens are properly encrypted at rest or in transit. Additionally, the code directly accesses Settings().secrets which could potentially expose secrets if not properly secured throughout the application lifecycle.

⚑ Recommended focus areas for review

Typo in Description

The description for GoogleCalendarReadNextEventsBlock mentions Google Sheets instead of Google Calendar, which is incorrect and misleading.

description="This block reads data from a Google Sheets spreadsheet.",
categories={BlockCategory.DATA},
Typo in Parameter

The description for the start_time parameter contains a typo "wehn to start" instead of "when to start".

description="wehn to start, defaults to timezone utc now",
default=datetime.now(tz=timezone.utc),
Empty Test Mock

The test_mock for _read_calendar returns an empty list with commented out example data, which may not provide adequate test coverage.

"_read_calendar": lambda *args, **kwargs: [
    # ["Name", "Score"],
    # ["Alice", "85"],
],

@github-actions github-actions bot added the size/l label May 7, 2025
Copy link

deepsource-io bot commented May 7, 2025

Here's the code health analysis summary for commits c594692..971aab2. View details on DeepSourceΒ β†—.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScriptβœ…Β SuccessView CheckΒ β†—
DeepSource Python LogoPythonβœ…Β Success
❗ 3 occurences introduced
View CheckΒ β†—

πŸ’‘ If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

netlify bot commented May 7, 2025

βœ… Deploy Preview for auto-gpt-docs canceled.

Name Link
πŸ”¨ Latest commit 971aab2
πŸ” Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/6821c0808a197a00085f7609

@github-project-automation github-project-automation bot moved this from πŸ†• Needs initial review to 🚧 Needs work in AutoGPT development kanban May 8, 2025
@ntindle
Copy link
Member Author

ntindle commented May 8, 2025

updated to make a bit more sense
image

@github-actions github-actions bot added size/xl and removed size/l labels May 8, 2025
@ntindle ntindle requested a review from kcze May 8, 2025 16:46
@ntindle
Copy link
Member Author

ntindle commented May 8, 2025

Thanks for the review @kcze ! changes made

@Torantulino Torantulino requested a review from Copilot May 9, 2025 17:15
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

kcze
kcze previously requested changes May 9, 2025
Copy link
Contributor

@majdyz majdyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's with PR description here, why it describes another PR

@ntindle ntindle changed the title feat: initial google calendar feat(blocks): initial google calendar May 12, 2025
@ntindle ntindle requested review from kcze, majdyz and Copilot May 12, 2025 09:33
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@ntindle ntindle dismissed kcze’s stale review May 12, 2025 18:20

Zamil approved

@ntindle ntindle enabled auto-merge May 12, 2025 18:21
@ntindle ntindle added this pull request to the merge queue May 12, 2025
Merged via the queue into dev with commit 79cc087 May 12, 2025
23 checks passed
@ntindle ntindle deleted the ntindle/secrt-1234-google-calendar branch May 12, 2025 18:48
@github-project-automation github-project-automation bot moved this from 🚧 Needs work to βœ… Done in AutoGPT development kanban May 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: βœ… Done
Development

Successfully merging this pull request may close these issues.

3 participants