Skip to content

feat: initial google calendar #9920

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: dev
Choose a base branch
from
Open

Conversation

ntindle
Copy link
Member

@ntindle ntindle commented May 7, 2025

Using sync code in the async route often introduces a blocking
event-loop code that impacts stability.

The current RPC system only provides a synchronous client to call the
service endpoints.
The scope of this PR is to provide an entirely decoupled signature
between client and server, allowing the client can mix & match async &
sync options on the client code while not changing the async/sync nature
of the server.

Changes 🏗️

  • Add support for flexible async/sync RPC client.
  • Migrate scheduler client to all-async client.

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • Scheduler route test.
    • Modified service_test.py
    • Run normal agent executions

Changes 🏗️

Checklist 📋

For code changes:

  • I have clearly listed my changes in the PR description
  • I have made a test plan
  • I have tested my changes according to the test plan:
    • ...
Example test plan
  • Create from scratch and execute an agent with at least 3 blocks
  • Import an agent from file upload, and confirm it executes correctly
  • Upload agent to marketplace
  • Import an agent from marketplace and confirm it executes correctly
  • Edit an agent from monitor, and confirm it executes correctly

For configuration changes:

  • .env.example is updated or already compatible with my changes
  • docker-compose.yml is updated or already compatible with my changes
  • I have included a list of my configuration changes in the PR description (under Changes)
Examples of configuration changes
  • Changing ports
  • Adding new services that need to communicate with each other
  • Secrets or environment variable changes
  • New or infrastructure changes such as databases

@ntindle ntindle requested a review from a team as a code owner May 7, 2025 18:24
@ntindle ntindle requested review from Swiftyos and aarushik93 and removed request for a team May 7, 2025 18:24
@github-project-automation github-project-automation bot moved this to 🆕 Needs initial review in AutoGPT development kanban May 7, 2025
Copy link

netlify bot commented May 7, 2025

Deploy Preview for auto-gpt-docs-dev canceled.

Name Link
🔨 Latest commit 657299f
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs-dev/deploys/681d8dc67da3c40008142b6b

Copy link

qodo-merge-pro bot commented May 7, 2025

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

⏱️ Estimated effort to review: 3 🔵🔵🔵⚪⚪
🧪 No relevant tests
🔒 Security concerns

OAuth token handling:
The code is handling sensitive OAuth tokens and credentials. While the implementation uses Secret types for tokens, there's no validation that the tokens are properly encrypted at rest or in transit. Additionally, the code directly accesses Settings().secrets which could potentially expose secrets if not properly secured throughout the application lifecycle.

⚡ Recommended focus areas for review

Typo in Description

The description for GoogleCalendarReadNextEventsBlock mentions Google Sheets instead of Google Calendar, which is incorrect and misleading.

description="This block reads data from a Google Sheets spreadsheet.",
categories={BlockCategory.DATA},
Typo in Parameter

The description for the start_time parameter contains a typo "wehn to start" instead of "when to start".

description="wehn to start, defaults to timezone utc now",
default=datetime.now(tz=timezone.utc),
Empty Test Mock

The test_mock for _read_calendar returns an empty list with commented out example data, which may not provide adequate test coverage.

"_read_calendar": lambda *args, **kwargs: [
    # ["Name", "Score"],
    # ["Alice", "85"],
],

@github-actions github-actions bot added the size/l label May 7, 2025
Copy link

deepsource-io bot commented May 7, 2025

Here's the code health analysis summary for commits 089e7aa..657299f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
DeepSource Python LogoPython✅ Success
❗ 3 occurences introduced
View Check ↗

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

Copy link

netlify bot commented May 7, 2025

Deploy Preview for auto-gpt-docs canceled.

Name Link
🔨 Latest commit 657299f
🔍 Latest deploy log https://app.netlify.com/sites/auto-gpt-docs/deploys/681d8dc6237f460008b3f791

@github-project-automation github-project-automation bot moved this from 🆕 Needs initial review to 🚧 Needs work in AutoGPT development kanban May 8, 2025
@ntindle
Copy link
Member Author

ntindle commented May 8, 2025

updated to make a bit more sense
image

@github-actions github-actions bot added size/xl and removed size/l labels May 8, 2025
@ntindle ntindle requested a review from kcze May 8, 2025 16:46
@ntindle
Copy link
Member Author

ntindle commented May 8, 2025

Thanks for the review @kcze ! changes made

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 🚧 Needs work
Development

Successfully merging this pull request may close these issues.

2 participants