Fix typo in sl_sleeptimer_hal_rtc.c#54
Open
ByteSnapAnthony wants to merge 1 commit intoSiliconLabs:gsdk_4.3from
Open
Fix typo in sl_sleeptimer_hal_rtc.c#54ByteSnapAnthony wants to merge 1 commit intoSiliconLabs:gsdk_4.3from
ByteSnapAnthony wants to merge 1 commit intoSiliconLabs:gsdk_4.3from
Conversation
Corrects LFACLKSEL typo om `sli_sleeptimer_set_pm_em_requirement` function
|
Hi @ByteSnapAnthony Thanks for submitting this PR. I'll reach out to someone from our platform team to notify them of this finding. |
|
@ByteSnapAnthony Thanks again for finding this. It's on the platform team's radar now and should be fixed in an upcoming patch release |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sl_sleeptimer_hal_rtc.c incorrectly attempts to use
CMU_LFCLKSEL_LFA_LFRCOandCMU_LFCLKSEL_LFA_LFXOmacros to determine Power Manager lowest allowed power state in thesli_sleeptimer_set_pm_em_requirementfunction.This fails to build on a project targeting an EFM32GG12B110F1024GM64 processor and would likely fail on any other part that has the LFA clock select mask