Conversation
lmolina
changed the title
Collaborator
Author
|
@BugBot run |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit f56044f. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Medium risk because it changes capability-gating logic for
FUNC_ID_SERIALAPI_SETUP, which can enable/disable features (e.g., Long Range) depending on firmware-reported bitmasks.Overview
Corrects the bit position math in
SupportsSerialAPISetup_func()so extendedSerialAPISetupsubcommand support is checked against the proper bit withincapabilities.supported_serialapi_bitmask.This fixes an off-by-one error for subcommands in the
1..8and9..16ranges, which affects feature checks likeSerialAPI_SupportsLR().Reviewed by Cursor Bugbot for commit f56044f. Bugbot is set up for automated code reviews on this repo. Configure here.