Fix: Node List len is reported 0x00 when LR node is inlcuded#54
Open
harshithChukka wants to merge 2 commits into
Open
Fix: Node List len is reported 0x00 when LR node is inlcuded#54harshithChukka wants to merge 2 commits into
harshithChukka wants to merge 2 commits into
Conversation
Collaborator
|
Thanks for reporting and sharing the PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When an LR node is included, ZIPGW may send Node List Report / Failed Node List Report with LR node list length as 0x00 even though the Serial API returns a valid LR bitmask. This can hide LR nodes from downstream consumers.
Bug 1: find_min_bitmask_len() stops at first zero byte => This assumes non-zero bytes are contiguous from index 0, which is not valid for LR bitmasks.
Bug 2: Out-of-bounds read in BuildFailedNodeListFrame() => BuildFailedNodeListFrame() passed MAX_NODEMASK_LENGTH (500) instead of MAX_LR_NODEMASK_LENGTH (468) to find_min_bitmask_len():