SOSC - Update latest coding convention submodule and some documents #6
Conversation
|
Hi reviewers As, SiliconLabsSoftware/devs-coding-convention-tool has changed new version. So I update submodule for this repo. Please help me to review it. |
silabs-CongD
force-pushed
the
feature/update_workflows
branch
from
2dd739d to
78afc00
Compare
silabs-CongD
changed the title
|
Hey @silabs-CongD |
AndrasZiegler
left a comment
AndrasZiegler
left a comment
There was a problem hiding this comment.
Fix code convention tool findings.
There was a problem hiding this comment.
Pull Request Overview
This pull request updates several GitHub Actions workflows to align with the latest coding conventions and documentation standards.
- Updated the security scan workflow to trigger on pull_request events with a runner change.
- Revised the CLA Assistant workflow to use a new GitHub App token and updated document links.
- Modified the code convention check workflow by adjusting branch inputs, updating file paths, and adding a patch upload step.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| .github/workflows/04-TruffleHog-Security-Scan.yml | Changed event triggers and updated the runner version. |
| .github/workflows/01-CLA-Assistant.yml | Updated issue comment triggers, token usage, and document link. |
| .github/workflows/00-Check-Code-Convention.yml | Modified branch input, file paths, installation commands, and added patch upload. |
| .github/coding-convention-tool | Updated submodule commit reference. |
Comments suppressed due to low confidence (1)
.github/workflows/00-Check-Code-Convention.yml:58
- The removal of cppcheck installation might reduce static analysis coverage; please verify that cppcheck is no longer required for your code convention validation.
sudo apt-get install clang-tidy
| jobs: | ||
| trufflehog_scan: | ||
| runs-on: ubuntu-24.04 | ||
| runs-on: ubuntu-latest |
There was a problem hiding this comment.
Switching from a fixed runner version to 'ubuntu-latest' may introduce unexpected environment changes; consider pinning to a specific version if consistent behavior is required.
| runs-on: ubuntu-latest | |
| runs-on: ubuntu-22.04 |
| sudo make install | ||
| echo "Uncrustify has been installed successfully!" | ||
| cd ../../ | ||
| sudo cp ./.github/coding-convention-tool/tools/uncrustify/uncrustify.cfg ./uncrustify/uncrustify.cfg |
There was a problem hiding this comment.
Ensure that the new file path for uncrustify.cfg reflects the updated submodule structure; an incorrect path may result in file not found errors during execution.
| sudo cp ./.github/coding-convention-tool/tools/uncrustify/uncrustify.cfg ./uncrustify/uncrustify.cfg | |
| sudo cp ./.github/coding-convention-tool/submodules/uncrustify/uncrustify.cfg ./uncrustify/uncrustify.cfg |
This comment was marked as off-topic.
This comment was marked as off-topic.
silabs-CongD
force-pushed
the
feature/update_workflows
branch
from
c04be88 to
964c047
Compare
|
Hi @AndrasZiegler, please help me re-review this PR again. If it fine, please help me to approve it. PR need 1 approved by reviewer with write access to allow merged. Thanks. |
silabs-ThanhNgo
left a comment
silabs-ThanhNgo
left a comment
There was a problem hiding this comment.
Hi Cong,
Please check my comments and update if necessary
Thanks
| name: 02-Build-Firmware | ||
| ## By default this workflow runs on Github hosted runners. This is not free for internal and private repositories | ||
| ## It is recommended to run this job on a self-hosted runner for non public repository | ||
| ## Uncomment the needed runs-on command. |
There was a problem hiding this comment.
Did you check if this workflow works?
| @@ -1,69 +0,0 @@ | |||
| <table border="0"> | |||
There was a problem hiding this comment.
Why do you delete the Readme files?
Same for the other Readme files
Description
Related Issue
Closes #<issue_number>
Changes Made
Checklist
Screenshots (if applicable)
Additional Notes