Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Sep 29, 2025

Update SDK versions in docker/version ✅ COMPLETED

Changes made:

  • ✅ Updated SISDK_Tag from v2025.6.1 to v2025.6.2 in docker/version
  • ✅ Updated WiFI_SDK_Tag from v3.5.1 to v3.5.2 in docker/version
  • ✅ Reverted unintended file mode change to docker/build.sh

Verification completed:

  • ✅ GitHub workflow version parsing tested and working
  • ✅ Docker build script version extraction tested and working
  • ✅ End-to-end version flow verified
  • ✅ Dockerfile ARG usage confirmed correct
  • ✅ All parsing logic works with new versions
  • ✅ File permissions restored to original state

Implementation details:

  • Modified docker/version file which is the authoritative source for SDK versions
  • The GitHub workflow reads these versions and constructs a VERSION tag
  • The docker/build.sh script parses the tag to extract individual SDK versions
  • The Dockerfile uses these as ARG variables to download the correct SDK releases
  • Reverted build.sh file mode back to original 644 permissions

Impact:

  • The build action now uses the latest SDK releases as specified
  • SISDK v2025.6.2 will be downloaded from GitHub releases
  • WiFI SDK v3.5.2 will be cloned from the wiseconnect repository
  • No breaking changes to existing functionality
  • File permissions restored to original state
Original prompt

Update the SDK versions in docker/version:

  • SISDK_Tag should be set to v2025.6.2
  • WiFI_SDK_Tag should be set to v3.5.2
    This ensures the build action uses the latest SDK releases.
*This pull request was created as a result of the following prompt from Copilot chat.* > Update the SDK versions in docker/version: > - SISDK_Tag should be set to v2025.6.2 > - WiFI_SDK_Tag should be set to v3.5.2 > This ensures the build action uses the latest SDK releases.

💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI changed the title [WIP] Update SDK versions in docker/version to v2025.6.2 and v3.5.2 Update SDK versions to v2025.6.2 and v3.5.2 Sep 29, 2025
Copilot AI requested a review from Sarthak-Shaha September 29, 2025 20:39
@Sarthak-Shaha
Copy link
Contributor

@copilot Why was the file mode for build.sh was changed?

@github-actions
Copy link

github-actions bot commented Sep 29, 2025


Thank you for your submission, we really appreciate it. Like many open-source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution. For privacy information, see our Privacy Notice. You can sign the CLA by just posting a Pull Request Comment same as the below format.


I have read the CLA Document and I hereby sign the CLA behalf on myself, e-mail: [email protected]

or

I have read the CLA Document and I hereby sign the CLA behalf of my company, e-mail: [email protected]

Signature is valid for 6 months.


1 out of 2 committers have signed the CLA.
✅ (Sarthak-Shaha)[https://github.com/Sarthak-Shaha]
❌ @Copilot
This bot will be retriggered when the Contributor License Agreement comment has been provided. Posted by the CLA Assistant Lite bot.

Copy link
Contributor Author

Copilot AI commented Sep 29, 2025

@copilot Why was the file mode for build.sh was changed?

The file mode change was unintentional. I ran chmod +x docker/build.sh during testing to verify the build script worked with the new SDK versions, and that change was accidentally committed along with the version updates. I've reverted the file mode back to its original 644 permissions in commit 2c66a5f while preserving the intended SDK version updates.

@Sarthak-Shaha Sarthak-Shaha marked this pull request as ready for review October 3, 2025 16:09
@mkardous-silabs mkardous-silabs merged commit 83a4738 into main Oct 3, 2025
6 of 8 checks passed
@mkardous-silabs mkardous-silabs deleted the copilot/fix-0ef07d99-d91d-45ca-b707-031d90d7c599 branch October 3, 2025 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants