NOJIRA - Cleanup unused configs in our slcps #326
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t exist. Add condition to SL_MBEDTLS_KEY_EXCHANGE_PSK_ENABLED as it is only needed for thread coap lib
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes unused configuration entries from Thread application SLCP files after discovering that the matter_thread_coap_cert_libs component no longer exists. The cleanup involves removing configurations that were conditionally enabled based on this nonexistent component and updating the condition for SL_MBEDTLS_KEY_EXCHANGE_PSK_ENABLED to use the correct ot_coap_cert_libs condition.
Key changes:
- Removed unused ECDHE-ECDSA and CoAP configurations conditioned on nonexistent components
- Updated
SL_MBEDTLS_KEY_EXCHANGE_PSK_ENABLEDto be conditional onot_coap_cert_libs
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| slc/apps/window-app/thread/window-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/thermostat/thread/thermostat.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/refrigerator-app/thread/refrigerator-app.slcp | Removed obsolete configurations and updated PSK condition (incomplete cleanup) |
| slc/apps/platform-template/thread/platform-template.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/performance-test-app/thread/performance-test-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/onoff-plug-app/thread/onoff-plug-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/multi-sensor-app/thread/multi-sensor-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/lock-app/thread/lock-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/lighting-app/thread/trustzone/lighting-ns.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/lighting-app/thread/lighting-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/light-switch-app/thread/light-switch-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/fan-control-app/thread/fan-control-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/dishwasher-app/thread/dishwasher-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/closure-app/thread/closure-app.slcp | Removed obsolete configurations and updated PSK condition |
| slc/apps/air-quality-sensor-app/thread/air-quality-sensor-app.slcp | Removed obsolete configurations and updated PSK condition |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Link:
n/a
Description of Problem/Feature:
While working on #324, I noticed that
matter_thread_coap_cert_libscomponent didn't exist anymore and was conditional on a few configuration defines in all our thread slcp. This indicates that this listed configuration are not needed/used.Description of Fix/Solution:
matter_thread_coap_cert_libscondition.[ot_coap_cert_libs]onSL_MBEDTLS_KEY_EXCHANGE_PSK_ENABLEDconfiguration. It is only required when using thread cert libsTesting Done:
Build and commission the thread lighting-app.