[SL-ONLY] MATTER-6651: Validate APIs in CI (#1087) (#1127) - #1169
[SL-ONLY] MATTER-6651: Validate APIs in CI (#1087) (#1127)#1169Michael Duggan (miduggan24) wants to merge 1 commit into
Conversation
* [SL-ONLY] MATTER-6651: Validate APIs in CI (#1087) * initial commit api validation * add testign in ci * produce some ci failures * Revert "add testign in ci" This reverts commit dd3f8f5. * Revert "produce some ci failures" This reverts commit b6d5b66. * update versions * Fix three preprocessing and error message bugs in validate_crtp_apis.py - Fix ifdef/ifndef directive parsing by handling them before generic #if - Fix error message to correctly indicate missing APIs are from header not manifest - Strip comments before processing preprocessor directives to avoid false matches Applied via @cursor push command * fix yr * remove crtp refs * add doxygen brief --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> * Potential fix for pull request finding 'CodeQL / Workflow does not contain permissions' Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com> --------- Co-authored-by: Cursor Agent <cursoragent@cursor.com> Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
PR SummaryLow Risk Overview Introduces A Validate Silabs APIs GitHub Actions workflow runs on PRs to Reviewed by Cursor Bugbot for commit e3e44ad. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Workflow enabled despite missing apps
- Added 'if: false' to the validate-apis job to disable the workflow until all app refactors with AppTaskImpl.h headers are complete.
Or push these changes by commenting:
@cursor push 294e9d7517
Preview (294e9d7517)
diff --git a/.github/workflows/silabs-validate-apis.yaml b/.github/workflows/silabs-validate-apis.yaml
--- a/.github/workflows/silabs-validate-apis.yaml
+++ b/.github/workflows/silabs-validate-apis.yaml
@@ -22,6 +22,7 @@
validate-apis:
name: Validate APIs
runs-on: ubuntu-latest
+ if: false
steps:
- name: Checkout repository
uses: actions/checkout@v7You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit e3e44ad. Configure here.


Summary
cherry-pick of #1087
note that workflow is currently disabled as all app refactor changes need to be in otherwise CI will fail
Add CI validation for CRTP APIs so API contract changes require explicit manifest update in the same PR.
Add the following files:
silabs-crtp-apis.yamlvalidate_crtp_apis.py--bootstraparg on first setupsilabs-validate-apis.yamlvalidate_crtp_apis.py*Impl.hvalidate_crtp_apis.pyAppTaskImpl.h(andClosureManager) APIs against manifest fileAppTaskImpl.h(andClosureManagerImpl.h)Related issues
MATTER-6651
Testing
locally test script against:
temporary testing of each of the above in CI as well
https://github.com/SiliconLabsSoftware/matter_sdk/actions/runs/29934630457/job/88972898365