Skip to content

enhance interfacing with metadata #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
alessandrofelder wants to merge 2 commits into
base: master
Choose a base branch
from
Open

enhance interfacing with metadata #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4bb5c82
improve missing start_time error message
alessandrofelder Jun 4, 2020
cdc2b40
simplify start_time related assertion and error
alessandrofelder Jun 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion src/silverlabnwb/nwb_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,11 @@ def create_from_metadata(self, metadata_file, user=None, session_id=None):
try:
start_time = sessions[user]['start_time']
except KeyError:
raise ValueError("Start time for session not found!")
raise ValueError("Start time for session not found! "
"Please add a `start_time` parameter to sessions for user {}, "
"e.g. 'start_time: 10 May 2020 12:34:56'"
.format(user)
)
start_time = pd.to_datetime(
start_time, infer_datetime_format=True).tz_localize(
timezone('Europe/London'))
Expand Down
2 changes: 1 addition & 1 deletion tests/test_metadata_import.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ def test_no_start_time_fails(tmpdir, ref_data_dir):
with pytest.raises(ValueError) as exc_info:
with NwbFile(nwb_path, 'w') as nwb:
nwb.create_from_metadata(meta_path, user="A")
assert "Start time for session not found!" == str(exc_info.value)
assert "start_time" in str(exc_info.value)


def test_metadata_import_correct(tmpdir, ref_data_dir):
Expand Down