Skip to content

Conversation

@arsLibera
Copy link
Contributor

Add CPP unit tests

Current situation

We're looking to add support for JSON input files.
Add support for JSON input files

There's currently a Windows build failure.
Windows build fails #115

Release Notes

This change initiates CPP unit testing so we can more robustly migrate to the JSON serializer while continuing to support the legacy format.

  • No functional changes to the software.
  • gtest has been added.
  • Unit tests for the legacy deserialization format have been added.

Documentation

There are no functional changes, so no documentation needs to be added.

Testing

No new code. Unit Tests have been added to legacy code.

Code of Conduct & Contributing Guidelines

@arsLibera
Copy link
Contributor Author

@mrp089 @ktbolt

Pull request for introducing cpp unit tests along with some light refactoring to support it.

@mrp089 mrp089 self-requested a review February 10, 2025 14:39
Copy link
Member

@mrp089 mrp089 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! We can use your way of combining several unit tests for svMultiPhysics, too.

@mrp089 mrp089 merged commit 4aac52c into SimVascular:master Feb 10, 2025
3 checks passed
@arsLibera arsLibera mentioned this pull request Mar 16, 2025
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants