-
Notifications
You must be signed in to change notification settings - Fork 35
Function input feature for time-dependent boundary conditions #186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
ncdorn
wants to merge
41
commits into
SimVascular:master
Choose a base branch
from
ncdorn:time-dependent-function-bc
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Initial implementation of a time-dependent flow BC from an expression string. Currently results in a SEGFAULT.
Finished debugging time-dependent flow block
Initial implementation of a time-dependent flow BC from an expression string. Currently results in a SEGFAULT.
Finished debugging time-dependent flow block
Contributed by A. Partow
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current situation
given that @kharold23 has left the lab I have decided to take over #108. I have rebased this branch and now we can compare changes. thanks to @kharold23 for doing most of the heavy lifting on this a while back. There are extensive changes here so a code review may be in order.
Release Notes (from #108)
Documentation
Time-dependent boundary conditions can now be input using a function passed in as a string. The function is of the variable
t, or time. For example:"bc_values": { "fn": "2.0 * (4*atan(1.)) * COS(2.0 * (4*atan(1.)) * t)" }Testing
Test case
test_time_dependent_blockadded totest_io.py, which runs json filestimeDep_Flow.jsonandtimeDep_Pressure.json.Code of Conduct & Contributing Guidelines