fix: ScrollController is disposed when parent widget state changes (#289) #333
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes a lifecycle issue where
ChatListWidget
improperly disposes theScrollController
provided via the externalChatController
.Currently,
ChatController.scrollController
is passed into the widget tree and used in multiple places, including pagination and scrolling logic. However, theChatListWidget
callsscrollController.dispose()
in itsdispose()
method — even though it did not create the controller.This causes runtime exceptions (
ScrollController was disposed
) when parent widgets rebuild and reuse the same controller, which is a valid and supported use case.This PR changes:
scrollController.dispose()
andchatController.messageStreamController.close()
fromChatListWidget.dispose()
ChatController
)No behavior changes, just safer lifecycle management.
Checklist
fix:
).docs
and added dartdoc comments with///
.examples
ordocs
.Breaking Change?
Related Issues
N/A, but may be related to general lifecycle issues encountered by users embedding
ChatView
in reactive widget trees (e.g. GetX, Riverpod).