Fix regex pattern in AdaptivePlanningMode #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Corrects the expansionExpressionPattern regex in AdaptivePlanningMode.kt to properly match closing braces. Also bumps libraryVersion to 2.0.27 in gradle.properties.
There was a problem hiding this comment.
Pull Request Overview
This PR introduces file upload functionality to the web UI, refactors document reading utilities, and includes various code quality improvements across the codebase.
Key changes:
- File upload support in FileServlet with drag-and-drop, clipboard paste, and security validation
- Refactored
getReader()togetDocumentReader()across the codebase for clarity - Consolidated input file reading logic into
AbstractTask.getInputFileContent() - Added new IntelliJ task actions (ResearchPaper, PersuasiveEssay, NarrativeGeneration, BusinessProposal)
Reviewed Changes
Copilot reviewed 61 out of 64 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| FileServlet.kt | Added file upload via doPost, multipart config, drag-and-drop UI, and filename validation |
| SessionFileServlet.kt | Added @MultipartConfig annotation for file uploads |
| ApplicationServer.kt | Configured multipart settings for file upload servlet |
| ZipServlet.kt | Removed unused parsePath call |
| AbstractTask.kt | Added shared getInputFileContent() method to reduce code duplication |
| Multiple task files | Refactored to use getDocumentReader() and shared getInputFileContent() |
| AdaptivePlanningMode.kt | Fixed regex pattern with missing closing brace |
| AbstractFileTask.kt | Fixed file matching logic order |
| settings.gradle.kts | Commented out unused modules and reordered plugin configurations |
| Various files | Updated build configs, Java version targets, and added IntelliJ actions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| treatDocumentsAsText: Boolean = true, | ||
| ): String = (files ?: listOf()) | ||
| .flatMap { pattern: String -> | ||
| if(root.resolve(pattern).exists()) { |
There was a problem hiding this comment.
Missing space after 'if' keyword. Kotlin style guide recommends a space between control flow keywords and opening parentheses.
| distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip | ||
| validateDistributionUrl=true | ||
| networkTimeout=10000 | ||
| validateDistributionUrl=true |
There was a problem hiding this comment.
The property 'validateDistributionUrl' is defined twice (lines 4 and 6). The duplicate on line 6 should be removed.
Suggested change
| validateDistributionUrl=true |
Introduces Maven Central publishing configuration, including signing and Sonatype credentials, in core and jo-penai modules. Updates build scripts to use Java 17 toolchain explicitly and adjusts group/version properties for publishing. Adds .gitattributes for consistent line endings and reverts Gradle version to 8.10.2 for compatibility.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Corrects the expansionExpressionPattern regex in AdaptivePlanningMode.kt to properly match closing braces. Also bumps libraryVersion to 2.0.27 in gradle.properties.