.

Author: SimonCropp

src/GraphQL.EntityFramework.Analyzers/FieldBuilderResolveAnalyzer.cs

@@ -164,10 +164,6 @@ bool IsInEfGraphType(SyntaxNode node, SemanticModel semanticModel)
     bool AccessesNavigationProperties(LambdaExpressionSyntax lambda, SemanticModel semanticModel)
     {
         var body = lambda.Body;
-        if (body == null)
-        {
-            return false;
-        }
 
         // Find all member access expressions in the lambda
         var memberAccesses = body.DescendantNodesAndSelf()
@@ -209,19 +205,16 @@ bool IsContextSourceAccess(MemberAccessExpressionSyntax memberAccess, out Member
         MemberAccessExpressionSyntax? sourceAccess = null;
 
         // Walk up the chain to find context.Source
-        while (current != null)
+        while (true)
         {
-            if (current.Expression is MemberAccessExpressionSyntax innerAccess &&
-                innerAccess.Name.Identifier.Text == "Source" &&
-                innerAccess.Expression is IdentifierNameSyntax identifier &&
+            if (current.Expression is MemberAccessExpressionSyntax { Name.Identifier.Text: "Source", Expression: IdentifierNameSyntax identifier } &&
                 (identifier.Identifier.Text == "context" || identifier.Identifier.Text == "ctx"))
             {
                 sourceAccess = current;
                 break;
             }
 
-            if (current.Expression is IdentifierNameSyntax id &&
-                id.Identifier.Text == "Source")
+            if (current.Expression is IdentifierNameSyntax { Identifier.Text: "Source" })
             {
                 // This might be a simplified lambda like: Source => Source.Property
                 sourceAccess = current;
@@ -282,7 +275,7 @@ bool IsSafeProperty(IPropertySymbol propertySymbol)
         return false;
     }
 
-    bool IsPrimaryKeyProperty(IPropertySymbol propertySymbol)
+    static bool IsPrimaryKeyProperty(IPropertySymbol propertySymbol)
     {
         var name = propertySymbol.Name;
 
@@ -314,7 +307,7 @@ bool IsPrimaryKeyProperty(IPropertySymbol propertySymbol)
         return false;
     }
 
-    bool IsForeignKeyProperty(IPropertySymbol propertySymbol)
+    static bool IsForeignKeyProperty(IPropertySymbol propertySymbol)
     {
         var name = propertySymbol.Name;
         var type = propertySymbol.Type;
@@ -334,7 +327,7 @@ bool IsForeignKeyProperty(IPropertySymbol propertySymbol)
         // Check if the type is a scalar type suitable for FK (int, long, Guid, etc.)
         // Unwrap nullable
         var underlyingType = type;
-        if (type is INamedTypeSymbol namedType && namedType.OriginalDefinition.SpecialType == SpecialType.System_Nullable_T)
+        if (type is INamedTypeSymbol { OriginalDefinition.SpecialType: SpecialType.System_Nullable_T } namedType)
         {
             underlyingType = namedType.TypeArguments[0];
         }

src/GraphQL.EntityFramework/GraphApi/FieldBuilderExtensions.cs

@@ -69,7 +69,7 @@ public static FieldBuilder<TSource, TReturn> Resolve<TDbContext, TSource, TRetur
                 }
                 catch (Exception exception)
                 {
-                    throw new Exception(
+                    throw new(
                         $"""
                         Failed to execute projection-based resolve for field `{field.Name}`
                         TSource: {typeof(TSource).FullName}
@@ -155,7 +155,7 @@ public static FieldBuilder<TSource, TReturn> ResolveAsync<TDbContext, TSource, T
                 }
                 catch (Exception exception)
                 {
-                    throw new Exception(
+                    throw new(
                         $"""
                         Failed to execute projection-based async resolve for field `{field.Name}`
                         TSource: {typeof(TSource).FullName}