New ignoreDynamicFontSize property for iOS
#132
Conversation
|
@SimonFairbairn possible to include this PR in next release please? |
leolobato
left a comment
leolobato
left a comment
There was a problem hiding this comment.
Requesting changes only for the indentation.
| font = UIFont.preferredFont(forTextStyle: textStyle) | ||
| } | ||
|
|
||
| if ignoreDynamicFontSize, let fontSize = fontSize { |
There was a problem hiding this comment.
Maybe it would be a good idea to fix indentation before merging?
| public var underlineLinks : Bool = false | ||
|
|
||
| /// **iOS only** : Setting this boolean to true will force using the exact size set for each style if available. | ||
| public var ignoreDynamicFontSize : Bool = false |
There was a problem hiding this comment.
This works and covers an genuine use case, but a better solution might be to use scaledFont(for:, maximumPointSize:) from UIFontMetrics on SwiftyMarkdown+iOS.swift instead?
Narayane
force-pushed
the
feature/ignore-dynamic-font-size
branch
from
40c26cd to
f5a9f49
Compare
|
Hi @leolobato, |
Thanks Seb |
|
@leolobato possible to merge it plz? |
|
@Narayane I don't have write permission to this repository. Only @SimonFairbairn should be able to merge and by the number of open, unmerged PRs, I suspect he doesn't have time to maintain this library anymore. I suggest you use your own fork with the fix on your project. |
3 participants
This PR adds a new
ignoreDynamicFontSizeproperty that is necessary if you want to set sizes for other styles thenitalicorboldwithout setting the fontName (you cannot get SFUI font via name).Inspired by an old but still opened PR.