README.md fixes and container on boot utility#3
Open
dovry wants to merge 5 commits intoSimpleHomelab:masterfrom
dovry:patch-1
Open
README.md fixes and container on boot utility#3dovry wants to merge 5 commits intoSimpleHomelab:masterfrom dovry:patch-1
dovry wants to merge 5 commits intoSimpleHomelab:masterfrom
dovry:patch-1
Conversation
Using 'unless-stopped' is generally considered better than 'always' for restarting containers, if they've been stopped it's usually for a good reason, and the containers should remain stopped until started again, not until the next boot.
Added URLs to the services Changed 'Organizer' to Organizr'
Kage1
approved these changes
Feb 8, 2019
Kage1
left a comment
Kage1
left a comment
There was a problem hiding this comment.
I agree with the change. This is the same thing I do w/ my containers. If I have manually stopped a container I do not want to to restart on it's own on a host reboot.
Kage1
approved these changes
Feb 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed the restart flag to not start manually stopped containers on boot
Added URLs to each service in the README file
fixed a typo in README