Skip to content

🎨 Palette: Add confirmation to Scratchpad Clear button #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sisyphean-a merged 1 commit into from
Jan 16, 2026
Merged

🎨 Palette: Add confirmation to Scratchpad Clear button #9

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .Jules/palette.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2024-05-23 - Webview Accessibility Gaps
**Learning:** VS Code Webviews are often implemented as raw HTML/JS and can easily miss standard accessibility features like `aria-label` or focus indicators, which native VS Code UI components handle automatically.
**Action:** When auditing VS Code extensions, prioritize checking any `webview` implementations for missing ARIA attributes and focus styles.

## 2024-06-15 - Lightweight Confirmation in Webviews
**Learning:** Standard modal dialogs are too heavy for micro-interactions within Webviews. A two-step button confirmation (Click -> Confirm? -> Click) provides safety without context switching.
**Action:** Implement inline state-based confirmation for destructive actions in Webviews, using `setTimeout` to auto-reset.
38 changes: 36 additions & 2 deletions src/features/scratchpad/scratchpad.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,6 +76,13 @@
outline: 1px solid var(--vscode-focusBorder);
outline-offset: 1px;
}
.btn-clear.confirm {
background-color: var(--vscode-button-destructiveBackground);
color: var(--vscode-button-destructiveForeground);
}
.btn-clear.confirm:hover {
background-color: var(--vscode-button-destructiveHoverBackground);
}
</style>
</head>
<body>
Expand All @@ -88,7 +95,7 @@
<div class="footer">
<span id="char-count" class="char-count" aria-live="polite">0 chars</span>
<div class="actions">
<button id="btn-clear" class="btn-clear" aria-label="Clear Scratchpad">
<button id="btn-clear" class="btn-clear" aria-label="Clear Scratchpad" title="Clear all content">
Clear
</button>
</div>
Expand All @@ -98,6 +105,7 @@
const textarea = document.getElementById('scratchpad');
const charCount = document.getElementById('char-count');
const btnClear = document.getElementById('btn-clear');
let clearTimeoutId;

// Debounce function
function debounce(func, delay) {
Expand All @@ -113,6 +121,17 @@
charCount.textContent = `${length} char${length !== 1 ? 's' : ''}`;
}

function resetClearButton() {
if (clearTimeoutId) {
clearTimeout(clearTimeoutId);
clearTimeoutId = null;
}
btnClear.textContent = 'Clear';
btnClear.classList.remove('confirm');
btnClear.setAttribute('aria-label', 'Clear Scratchpad');
btnClear.dataset.state = 'idle';
}

// 监听内容变化
const onInput = debounce(() => {
vscode.postMessage({
Expand All @@ -127,14 +146,29 @@
});

btnClear.addEventListener('click', () => {
if (textarea.value.length > 0) {
if (textarea.value.length === 0) return;

if (btnClear.dataset.state !== 'confirm') {
// First click: Request confirmation
btnClear.textContent = 'Confirm?';
btnClear.classList.add('confirm');
btnClear.setAttribute('aria-label', 'Confirm Clear Scratchpad');
btnClear.dataset.state = 'confirm';

// Reset after 3 seconds
clearTimeoutId = setTimeout(resetClearButton, 3000);
} else {
// Second click: Perform action
textarea.value = '';
updateCharCount();
onInput();
textarea.focus();
resetClearButton();
}
});

textarea.addEventListener('focus', resetClearButton);

// 接收来自扩展的消息
window.addEventListener('message', (event) => {
const message = event.data;
Expand Down