Check whether parameters are in nested porperties object. Required parameters added #22
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…should be done for the kind of parameters.json file format that is used in this repo
ivanbuzyka
changed the title
Author
|
Just forgot to add comments on second thing: there were 4 required parameters missing. So that when deploying it either asks for them or throws an exception. I think those 4 parameters should be also added at least to XP scaled template (probably also to other ones) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Without this check, that example PS script cannot read parameters from parameters.json file. I think this fix had already been added but it was removed due some reason (or overwritten)