Fix Vertical Layout #432
Merged
Fix Vertical Layout #432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Copilot reviewed 12 out of 27 changed files in this pull request and generated 1 comment.
Files not reviewed (15)
- samples/DrawWithImageSharp/DrawWithImageSharp.csproj: Language not supported
- src/SixLabors.Fonts/Tables/AdvancedTypographic/GSub/LookupType4SubTable.cs: Evaluated as low risk
- src/SixLabors.Fonts/FontMetrics.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/General/CMap/CMapSubTable.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/Shapers/UniversalShaper.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/Shapers/IndicShaper.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/Shapers/HangulShaper.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/Shapers/DefaultShaper.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/GSub/LookupType8SubTable.cs: Evaluated as low risk
- src/SixLabors.Fonts/FileFontMetrics.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/GSub/LookupType3SubTable.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/GSub/LookupType1SubTable.cs: Evaluated as low risk
- src/SixLabors.Fonts/Tables/AdvancedTypographic/GSub/LookupType2SubTable.cs: Evaluated as low risk
- src/SixLabors.Fonts/GlyphSubstitutionCollection.cs: Evaluated as low risk
- src/SixLabors.Fonts/StreamFontMetrics.cs: Evaluated as low risk
Comments suppressed due to low confidence (2)
src/SixLabors.Fonts/GlyphPositioningCollection.cs:95
- The parameter name isVerticalSubstitution is inconsistent with other parts of the code. It should be renamed to isVertical.
out bool isVerticalSubstitution,
src/SixLabors.Fonts/Tables/General/CMap/Format14SubTable.cs:139
- Ensure that the behavior of TryGetCodePoint always returning false is covered by tests.
public override bool TryGetCodePoint(ushort glyphId, out CodePoint codePoint)
| isVerticalSubstitution = false; | ||
| isDecomposed = false; | ||
|
|
||
| Tag vert = FeatureTags.VerticalAlternates; |
There was a problem hiding this comment.
The logic for checking vertical substitutions using FeatureTags.VerticalAlternates, FeatureTags.VerticalAlternatesAndRotation, and FeatureTags.VerticalAlternatesForRotation is duplicated in multiple places. This logic should be refactored into a separate method to avoid duplication and potential inconsistencies.
Suggested change
| Tag vert = FeatureTags.VerticalAlternates; | |
| isVerticalSubstitution = CheckVerticalSubstitution(glyph.Data.AppliedFeatures); |
Member
Author
There was a problem hiding this comment.
Logic is applied within a loop with other tests. Cannot abstract.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #429 by ensuring that we test against the substituted codepoint where possible. Also enhances CJK codepoint detection.