Fix Tracking of Last Line Break #447
Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 4 changed files in this pull request and generated no comments.
Files not reviewed (2)
- tests/Images/ReferenceOutput/Issue_446_A__WrappingLength_860_.png: Language not supported
- tests/Images/ReferenceOutput/Issue_446_B__WrappingLength_860_.png: Language not supported
|
Is there a way for me to run just this repo with the other ImageSharp NuGet packages or do I need to remove all NuGet package references and clone all the repos? |
You should be able to use the NuGet packages and add Fonts as a project reference pointing to this branch. That’s how we do the sample project in this repo. |
|
|
You should be able to do it like this. |
|
Doesn't build because of: Unable to find package Microsoft.NET.ILLink.Analyzers. No packages exist with this id in source(s): C:\Program Files\dotnet\library-packs, https://f.feedz.io/sixlabors/sixlabors/nuget/index.json No idea what that's about. |
|
It looks like it's not finding your standard NuGet package source. I wonder if it's a submodule thing, do you have a populated submodule |
|
Ah. Darn git behaviour, should init all submodules by default I say. Still now getting various errors along the lines of this for some reason: Duplicate 'System.Reflection.AssemblyCompanyAttribute' attribute |
|
Yeah because you tried to build without the submodules there’s now obj bin folders in all project folders. We use props to put them all under an artefacts folder. You’ll need to close VS, delete all those folders and reopen/build |
|
OK well I got it building now, but as I suspected, it seems to be using the old Fonts 2.0.8 pulled in by the Drawing NuGet package rather than the referenced Fonts project. |
|
Never mind, forgot to add the explicit project reference. It now seems to be using the project instead of the package, and I'm still seeing the bug happening. Trying to debug it to see why. |
|
Are you in the correct branch? |
|
Yeah, I discovered I wasn't. I'm now testing this branch with various stuff. So far it looks good. |
|
Yep, it seems to be good now with the stuff I have. |
Prerequisites
Description
Fixes #466
I had a bug in the tracking of the last wrapped position, have fixed that, cleaned up a little and added some caching so that the wrap measurements are not repeated unnecessarily.
@jez9999 if you have the time and fancy running your code against this branch to see if anything else appears that would be very useful. You seem to have the magic touch for finding issues.