Do not use default GlyphVector #481
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
Fixes #480
This pull request focuses on modernizing and simplifying the codebase by adopting collection expressions and more explicit empty initializations, as well as improving code clarity and safety. The changes primarily affect glyph loading and manipulation in the font rendering pipeline.
Key improvements include:
Modern C# Syntax and Code Simplification
Replaced
new()andArray.Empty<T>()with collection expressions ([]and[.. collection]) for initializing lists and arrays inCompositeGlyphLoaderandGlyphVector, making the code more concise and up-to-date with recent C# features. [1] [2] [3] [4]Used index-from-end (
^) operators for array assignments inGlyphVector.Hint, improving code readability when accessing elements from the end of an array.Robustness and Explicit Return Values
GlyphTable.GetGlyphto explicitly returnGlyphVector.Empty()instead ofdefault, clarifying intent and reducing ambiguity for empty glyphs.