Conversation
Upgrade silex to 2.0
|
|
||
| $app->register(new RabbitServiceProvider(), [ | ||
| $container['debug'] = function() { | ||
| return true; |
There was a problem hiding this comment.
This is a mock for tests, without this tests will not pass because doesn't exists debug function on container.
|
what about having pimple/pimple ^3.0 as a dependency and Silex as a suggestion ? I have not reviewed the code extensively but I don't think Silex is needed anymore |
|
This sounds good. But we will need to implement Console components directly that sounds good too. |
|
But if your PR #4 is approved this dependency is a suggestion too. |
|
ping |
|
Sorry for the late reply! |
|
@AntonStoeckl please update readme with link of my repository https://github.com/williamespindola/rabbitmq-service-provider |
|
@williamespindola |
|
Yes! Packagist is set up |
|
I have suggested your package as replacement. |
|
That's good! Thanks for the job. |
Upgrade silex to 2.0
issue #2