Skip to content

Conversation

@matkg
Copy link

@matkg matkg commented Sep 16, 2021

Im open for improvements as i just started using react.

#75

Pre-flight checklist

  • Unit tests for all non-trivial changes
  • Tested locally
  • Updated wiki

@SkalskiP
Copy link
Owner

Hello @Skiid 👋. Thank you very much for your interest in make-sense :) If that's ok, I'll do a review of your code over the weekend. I need to think if I have any better idea to implement those 2 functionalities than those that you proposed.

@matkg
Copy link
Author

matkg commented Sep 17, 2021

@SkalskiP Alright take your time. I had some problems finding the right code formatter and thats why there are so many changes in RectRenderEngine.ts.

@SkalskiP
Copy link
Owner

@Skiid don't worry I recently added linter I now I constantly push new formatting in PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants