Skip to content

chore(auth): remove the Apple review test account and its posting key #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Bielcx wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore(auth): remove the Apple review test account and its posting key #84

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions AGENTS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,25 +121,18 @@ QueryClientProvider
source of truth — `ios/` is regenerated from it by prebuild, so do not edit the
Podfile value directly.

4. **Test account in auth-provider:** Hardcoded credentials in `lib/auth-provider.tsx`
let Apple reviewers log in with a simple password instead of a HIVE posting key.
Remove immediately after Apple approves the app:
- Delete the "APPLE REVIEW TEST ACCOUNT CONFIGURATION" block (`TEST_USERNAME`,
`TEST_POSTING_KEY`, `TEST_SIMPLE_PASSWORD` constants).
- Delete the "APPLE REVIEW TEST ACCOUNT LOGIC" block inside the login function.
4. **HIVE RPC nodes:** Multiple fallback nodes configured in `hive-utils.ts`. If one fails, the client retries on the next. Don't hardcode a single node.

5. **HIVE RPC nodes:** Multiple fallback nodes configured in `hive-utils.ts`. If one fails, the client retries on the next. Don't hardcode a single node.
5. **Video autoplay:** Uses viewport tracking (`lib/ViewportTracker.tsx`). Videos auto-play when 60%+ visible, pause when scrolled away.

6. **Video autoplay:** Uses viewport tracking (`lib/ViewportTracker.tsx`). Videos auto-play when 60%+ visible, pause when scrolled away.

7. **Double padding on PostCard:** `components/Feed/PostCard.tsx` has its own
6. **Double padding on PostCard:** `components/Feed/PostCard.tsx` has its own
`paddingHorizontal: theme.spacing.md`, and the screens rendering it add
theirs: feed, profile and conversation each apply 16, while the conversation
drawer applies none. The card is therefore not inset the same everywhere.
When changing card padding, check all four call sites instead of assuming
the value is global.

8. **No test suite:** There are no automated tests in the project currently. The `scripts/` directory is empty.
7. **No test suite:** There are no automated tests in the project currently. The `scripts/` directory is empty.

## Environment Setup

Expand Down
37 changes: 0 additions & 37 deletions lib/auth-provider.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,29 +42,6 @@ import {
clearActiveSession,
} from './active-session';

// ============================================================================
// APPLE REVIEW TEST ACCOUNT CONFIGURATION
// ============================================================================
// This is a temporary solution for Apple App Store review process.
// Apple reviewers need a simple password, but HIVE posting keys are too long.
//
// INSTRUCTIONS:
// 1. Fill in the TEST_USERNAME with the account username
// 2. Fill in the TEST_POSTING_KEY with the actual HIVE posting key
// 3. Fill in the TEST_SIMPLE_PASSWORD with a simple password for Apple reviewers
//
// HOW IT WORKS:
// - When someone logs in with TEST_USERNAME and TEST_SIMPLE_PASSWORD,
// the app will internally use TEST_POSTING_KEY for all blockchain operations
// - The reviewer only needs to remember the simple password
// ============================================================================

const TEST_USERNAME: string = 'skatethread';
const TEST_POSTING_KEY: string = '5KPCy8wGKukimMDSu64dA3gUB5Utj5Qm3Vm3yueCzm1MG4Lk3XB'; // posting key is exposed intentionally and will be changed later
const TEST_SIMPLE_PASSWORD: string = '8wGKukim';

// ============================================================================

// Custom error types for authentication
export class AuthError extends Error {
constructor(message: string) {
Expand Down Expand Up @@ -332,20 +309,6 @@ export function AuthProvider({ children }: { children: React.ReactNode }) {
throw new AuthError('Username and posting key are required');
}

// ============================================================================
// APPLE REVIEW TEST ACCOUNT LOGIC
// ============================================================================
// Check if this is the Apple test account
if (TEST_USERNAME && normalizedUsername === TEST_USERNAME.toLowerCase()) {
// If they're using the simple password, replace it with the real posting key
if (TEST_SIMPLE_PASSWORD && postingKey === TEST_SIMPLE_PASSWORD) {
postingKey = TEST_POSTING_KEY;
}
// If they're using the posting key directly, that's fine too
// Continue with normal validation using the posting key
}
// ============================================================================

await validate_posting_key(normalizedUsername, postingKey);

// Encrypt the key
Expand Down