Skip to content

Fix order of subtraction #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix order of subtraction #69

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 8 additions & 5 deletions SketchUp/Sketchup/ComponentInstance.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,8 +460,10 @@ def split(instance)
end

# The subtract method is used to compute the boolean difference of the two
# instances representing manifold solid volumes (this - arg). If the specified
# objects (this and arg) do not represent manifold volumes, this method fails.
# instances representing manifold solid volumes (arg - this). Both instances
# are deleted and replaced by the result of subtracting the first from the
# second instance. If the specified objects (this and arg) do not represent
# manifold volumes, this method fails.
#
# @example
# entities = Sketchup.active_model.entities
Expand Down Expand Up @@ -536,9 +538,10 @@ def transformation=(transformation)
end

# The trim method is used to compute the (non-destructive) boolean difference
# of the two instances representing manifold solid volumes (this - arg). If
# the specified objects (this and arg) do not represent manifold volumes, this
# method fails.
# of the two instances representing manifold solid volumes (arg - this). The
# argument is deleted and replaced by the result of subtracting the first from
# the second instance. If the specified objects (this and arg) do not represent
# manifold volumes, this method fails.
#
# @example
# entities = Sketchup.active_model.entities
Expand Down
13 changes: 8 additions & 5 deletions SketchUp/Sketchup/Group.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,8 +525,10 @@ def split(group)
end

# The subtract method is used to compute the boolean difference of the two
# groups representing manifold solid volumes (this - arg). If the specified
# objects (this and arg) do not represent manifold volumes, this method fails.
# groups representing manifold solid volumes (arg - this). Both groups are
# deleted and replaced by the result of subtracting the first from the second
# group. If the specified objects (this and arg) do not represent manifold
# volumes, this method fails.
#
# @example
# entities = Sketchup.active_model.entities
Expand Down Expand Up @@ -640,9 +642,10 @@ def transformation=(transform)
end

# The trim method is used to compute the (non-destructive) boolean difference
# of the two groups representing manifold solid volumes (this - arg). If
# the specified objects (this and arg) do not represent manifold volumes, this
# method fails.
# of the two groups representing manifold solid volumes (arg - this). The
# argument is deleted and replaced by the result of subtracting the first from
# the second group. If the specified objects (this and arg) do not represent
# manifold volumes, this method fails.
#
# @example
# entities = Sketchup.active_model.entities
Expand Down