Skip to content

Conversation

MSP-Greg
Copy link
Contributor

@MSP-Greg MSP-Greg commented Jan 9, 2024

No description provided.

@MSP-Greg MSP-Greg changed the title USe Node.js 16 Use Node.js 16 Jan 9, 2024
@MSP-Greg
Copy link
Contributor Author

MSP-Greg commented Jan 9, 2024

Can you update 'Require status checks to pass' -> 'Status checks that are required.'?

https://github.com/SketchUp/testup-2/rules/267022?ref=refs%2Fheads%2Fmain

EDIT: Node.js, just like Ruby, allows one to install multiple versions. My default is currently 20.9.0, but I switch to 16.20.2 when I need to build TestUp.

@thomthom
Copy link
Member

I'm holding this PR until the other PRs are out of the way. Changing the required checks now would block the others that built with Node 10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants