Fix circular JSON marshalling errors #131
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
@Skitionek does this address the three issues and deal with the error in the failure? |
Skitionek
approved these changes
Oct 23, 2025
Owner
Skitionek
left a comment
Skitionek
left a comment
There was a problem hiding this comment.
Thank you for contribution.
It looks good to me, I will try to find the time over weekend to merge and release this fix.
src/MSTeams.js
Outdated
Comment on lines
293
to
309
| // Create a safe representation of the response to avoid circular reference errors | ||
| const safeResponse = {}; | ||
|
|
||
| // Safely copy properties, handling potential circular references | ||
| try { | ||
| safeResponse.status = response?.status; | ||
| safeResponse.statusText = response?.statusText; | ||
| safeResponse.headers = response?.headers ? JSON.parse(JSON.stringify(response.headers)) : undefined; | ||
| safeResponse.data = response?.data ? JSON.parse(JSON.stringify(response.data)) : undefined; | ||
| } catch (circularError) { | ||
| // If we still hit circular references, just include basic info | ||
| safeResponse.status = response?.status; | ||
| safeResponse.statusText = response?.statusText; | ||
| safeResponse.error = 'Response contained circular references'; | ||
| } | ||
|
|
||
| throw new Error('Failed to send notification to Microsoft Teams.\n' + 'Response:\n' + JSON.stringify(safeResponse, null, 2)); |
Author
|
I've added this to an action to test it, and there are still issues. The response is now being printed, and showing a status 200. That would suggest that the issue is elsewhere, likely due to this previous commit 39a7b67 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118 and fixes #125 and fixes #126.
Adds a test case to ensure that this is correct.