Skip to content

fix(config): stale console refs, ai-marker-syntax error, plop rename#3476

Merged
Skords-01 merged 11 commits into
mainfrom
claude/stale-refs-eslint-upgrades
Jun 9, 2026
Merged

fix(config): stale console refs, ai-marker-syntax error, plop rename#3476
Skords-01 merged 11 commits into
mainfrom
claude/stale-refs-eslint-upgrades

Conversation

@Skords-01

@Skords-01 Skords-01 commented Jun 9, 2026

Copy link
Copy Markdown
Owner

Summary

  • Renames branding text in plop generators and template files from hubchat/console-specialist to openclaw (generator names and output paths unchanged — only cosmetic/comment branding)
  • Creates tracking initiative 0021-react-hooks-v7-cleanup.md for the ~152 disabled react-hooks/* rules in eslint.baseline.js:146-178 that have no owner, ticket, or deadline; adds it to the initiatives README table

Note: Tasks 1 (stale tools/console path fixes in eslint.baseline.js, comments in source/docs) and Task 2 (ai-marker-syntax warn → error promotion) were already completed in prior audit work on the base branch (documented as ✅ in docs/90-work/audits/2026-06-08-codebase-cleanup-audit.md). This PR delivers the remaining two outstanding items from that audit.

Governing Skill

sergeant-tech-debt (refactor/dead code/lint baseline)

Playbook

No specific playbook — follows standard tech-debt cleanup pattern from docs/90-work/audits/2026-06-08-codebase-cleanup-audit.md § Запропонований план.

Verification

  • Confirmed no tools/console or apps/console references remain in active source/docs/config files (grep clean)
  • Confirmed sergeant-design/ai-marker-syntax is already set to "error" in eslint.baseline.js:194
  • Plop template changes are branding-only: generator names (hubchat-tool, new-console-specialist), templateFile paths, and generated output paths are all unchanged
  • Initiative file 0021-react-hooks-v7-cleanup.md has valid Status: Proposed and Agent-ready: needs-decision headers per lint:initiative-status-sync and lint:initiative-agent-ready gates

Docs and Governance

  • docs/90-work/initiatives/README.md updated with new initiative row
  • docs/90-work/initiatives/0021-react-hooks-v7-cleanup.md created
  • All changes sourced from and cross-referenced to docs/90-work/audits/2026-06-08-codebase-cleanup-audit.md

Risk and Rollout

Low risk — branding/comment changes only (no functional code changes). Initiative doc is read-only metadata.

Hard Rule #15

Internal docs written in Ukrainian per convention. Changes affect config files (JS comments) and initiative doc.

https://claude.ai/code/session_01LBMY124XpqUHQ9ed8yCRzA


Generated by Claude Code


Summary by cubic

Updates OpenClaw branding in plop templates and fixes a Kyiv timezone flake in toLocalISODate tests. Refreshes governance docs and regenerates indexes/diagrams (incl. freshness-dashboard.html).

  • Bug Fixes

    • Stabilize toLocalISODate property tests: generate hours 0–20 and compare 06:00/20:00 UTC to avoid Europe/Kyiv day-boundary; removes DST-related flakes (tests only).
  • Governance

    • Add docs/90-work/initiatives/0021-react-hooks-v7-cleanup.md for disabled react-hooks/* rules; update C3 diagram validation date; regenerate knowledge graph, retrieval index, symbol catalogs, repo/service maps, and architecture diagrams.

Written for commit 6ca629a. Summary will update on new commits.

Review in cubic

claude added 2 commits June 9, 2026 00:36
… branding

Update branding-only text in plop generators and template files:
- plopfile.mjs: update hubchat-tool description to reference OpenClaw
- new-console-specialist/agent.ts.hbs: replace "Telegram-console specialist"
  with "Telegram-openclaw specialist" and update gen command reference
- new-console-specialist/agent.test.ts.hbs: replace "console specialist"
  with "openclaw specialist"

Generated file paths are unchanged (generator names, templateFile paths,
and output paths remain identical).

https://claude.ai/code/session_01LBMY124XpqUHQ9ed8yCRzA
Create 0021-react-hooks-v7-cleanup.md to track the ~152 disabled
react-hooks/* rules in eslint.baseline.js:146-178 that have no owner,
ticket, or deadline. This blocks promoting react-hooks/v7 rules to error.

Initiative is Proposed/needs-decision — work starts no earlier than
Sprint 9 (2026-07-07), target close 2026-09-09. Add to README table.

Sourced from 2026-06-08-codebase-cleanup-audit.md § Тема 4.

https://claude.ai/code/session_01LBMY124XpqUHQ9ed8yCRzA
@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
sergeant Ready Ready Preview, Comment Jun 9, 2026 4:07pm

@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@Skords-01, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 17 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 6f8cfe2c-8065-4ea4-bd87-72c077399257

📥 Commits

Reviewing files that changed from the base of the PR and between 6e79498 and 6ca629a.

📒 Files selected for processing (6)
  • docs/02-engineering/architecture/diagrams/c3-workspaces.md
  • docs/90-work/initiatives/0021-react-hooks-v7-cleanup.md
  • packages/shared/src/utils/date.property.test.ts
  • plop-templates/new-console-specialist/agent.test.ts.hbs
  • plop-templates/new-console-specialist/agent.ts.hbs
  • plopfile.mjs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch claude/stale-refs-eslint-upgrades

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

claude added 3 commits June 9, 2026 01:52
…-boundary mismatch

toLocalISODate uses Europe/Kyiv timezone. UTC hours 21–23 cross into the next
Kyiv calendar day (UTC+2/+3 offset), causing property-test assertions that
compare UTC date fields to Kyiv-formatted output to fail. Scoping generated
hours to 0–20 and using fixed hours 6/20 in the time-of-day invariant test
avoids the DST boundary without weakening coverage.

Pre-existing bug in main (merged via PR #3402); backported fix from PR #3479.

https://claude.ai/code/session_01LBMY124XpqUHQ9ed8yCRzA
@Skords-01 Skords-01 enabled auto-merge (squash) June 9, 2026 13:36
@Skords-01 Skords-01 closed this Jun 9, 2026
auto-merge was automatically disabled June 9, 2026 13:56

Pull request was closed

@Skords-01 Skords-01 reopened this Jun 9, 2026
@Skords-01 Skords-01 merged commit a62e2cb into main Jun 9, 2026
40 of 59 checks passed
@Skords-01 Skords-01 deleted the claude/stale-refs-eslint-upgrades branch June 9, 2026 16:07
@github-actions github-actions Bot added the size/S label Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

⏱️ CI Pipeline Duration Report

Based on the last 50 successful runs on the default branch.

Overall Pipeline

Metric Value
p50 6m 26s
p95 7m 55s
p99 9m 3s
Current run 47m 58s
vs p95 +505.9%

Trend (last 20 runs): ▃▃▁▂▃▃▃▂▃▃▂▂▄▃▃▆▅▄█▆

Per-Job Breakdown

Job p50 p95 p99 Current vs p95
Accessibility (axe-core) 2m 5s 2m 21s 2m 23s 0s -100.7%
Commit messages (commitlint) 0s 0s 0s 1m 50s N/A
Critical-flow E2E (Playwright) 1m 36s 1m 44s 1m 44s 2m 32s +46.2%
Migration lint (AGENTS rule 0s 0s 0s 10s N/A
Pipeline duration (p95 trend) 26s 27s 27s
Secret scan (gitleaks) 8s 11s 11s 10s -9.1%
Smoke E2E (Playwright) 1m 26s 1m 40s 1m 40s
Test coverage (vitest) 2m 4s 2m 33s 2m 33s 12m 9s +376.5%
Workflow lint (actionlint) 7s 7s 7s 8s +14.3%
check 4m 12s 4m 54s 5m 6s 40s -86.4%
tsconfig strict guard (PR-1.A) 5s 14s 14s 7s -50.0%

⚠️ Warning: Current run (47m 58s) exceeds p95 + 20% threshold (9m 30s). Consider reviewing slow jobs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants