test(eslint-plugins,shared): expand ESLint fixture cases + extend property-based tests

[Skords-01]

Summary

• P2-2 (ESLint plugin coverage): Adds 3 GOOD-fixture edge cases to no-foreign-module-accent (no-className element, accentless utilities, same-module accent) and 5 new cases to no-arbitrary-text-size (exempt DS primitive contract for 11px/12px, explicit text-xs/text-sm preset GOOD fixtures, BAD cases for text-[11px]/text-[12px] in non-exempt module files). Both rules now have 32+ tests with coverage across all realistic contributor-written shapes.
• P2-4 (Property-based tests): Extends the three existing property suites in packages/shared/src/utils/ — adds monotonicity + integer round-trip to macros, Kyiv-offset boundary invariant + order-preservation to date, and output-length bound to speech. All use the existing seeded PRNG harness (mulberry32, seed 42) structured for future fast-check migration.

Governing Skill

sergeant-tech-debt (expanding test coverage for owned packages, no surface-touching).

Playbook

No dedicated playbook — standard test-expansion pattern from docs/audits/2026-05-13-testing-devx-roast.md P2-2 and P2-4.

Verification

• pnpm --filter eslint-plugin-sergeant-design test — node:test runner, no deps needed; all cases use the in-repo index.js.
• pnpm --filter @sergeant/shared test — vitest run, all new properties use the seeded PRNG (no network or build deps).
• pnpm --filter @sergeant/shared typecheck — TS types for new properties are identical to existing suite patterns.

Local deps not installed in this environment; CI (turbo run test) will validate on push.

Docs and Governance

• I updated docs that changed with the behavior, contract, workflow, or rollout.
• I checked whether AGENTS.md needed an update.
• I checked whether a playbook or skill needed an update.
• I checked whether governance docs or review docs needed an update.

Updated docs:

• docs/90-work/initiatives/README.md — initiative Simplify Measurements header to a single hint card #17 marked Closed (status sync fix)

Risk and Rollout

Test-only change. No runtime code touched. All new fixtures are append-only to existing test files.

Hard Rule #15

• I read AGENTS.md before coding.
• Internal docs I touched are in Ukrainian.
• I did not use --no-verify.

References: P2-2 and P2-4 in docs/audits/2026-05-13-testing-devx-roast.md.

https://claude.ai/code/session_01LBMY124XpqUHQ9ed8yCRzA

[vercel]

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Actions	Updated (UTC)
sergeant	Ready	Preview, Comment	Jun 9, 2026 4:12pm

[coderabbitai]

Warning

Review limit reached

@Skords-01, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 56 minutes and 12 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 9bb34b63-c899-4597-a3c4-21a97dbd429c

📥 Commits

Reviewing files that changed from the base of the PR and between 6e79498 and 0473d29.

📒 Files selected for processing (6)

• docs/02-engineering/architecture/diagrams/c3-workspaces.md
• packages/eslint-plugin-sergeant-design/__tests__/no-arbitrary-text-size.test.mjs
• packages/eslint-plugin-sergeant-design/__tests__/no-foreign-module-accent.test.mjs
• packages/shared/src/utils/date.property.test.ts
• packages/shared/src/utils/macros.property.test.ts
• packages/shared/src/utils/speech.property.test.ts

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch claude/package-tests-eslint-propbased

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[github-actions]

⏱️ CI Pipeline Duration Report

Based on the last 50 successful runs on the default branch.

Overall Pipeline

Metric	Value
p50	6m 26s
p95	7m 55s
p99	9m 3s
Current run	41m 0s
vs p95	+417.9%

Trend (last 20 runs): ▃▃▁▂▃▃▃▂▃▃▂▂▄▃▃▆▅▄█▆

Per-Job Breakdown

Job	p50	p95	p99	Current	vs p95
Accessibility (axe-core)	2m 5s	2m 21s	2m 23s	0s	-100.0%
Commit messages (commitlint)	0s	0s	0s	1m 17s	N/A
Critical-flow E2E (Playwright)	1m 36s	1m 44s	1m 44s	2m 49s	+62.5%
Migration lint (AGENTS rule	0s	0s	0s	9s	N/A
Pipeline duration (p95 trend)	26s	27s	27s	—	—
Secret scan (gitleaks)	8s	11s	11s	11s	+0.0%
Smoke E2E (Playwright)	1m 26s	1m 40s	1m 40s	—	—
Test coverage (vitest)	2m 4s	2m 33s	2m 33s	13m 1s	+410.5%
Workflow lint (actionlint)	7s	7s	7s	7s	+0.0%
check	4m 12s	4m 54s	5m 6s	46s	-84.4%
tsconfig strict guard (PR-1.A)	5s	14s	14s	8s	-42.9%

⚠️ Warning: Current run (41m 0s) exceeds p95 + 20% threshold (9m 30s). Consider reviewing slow jobs.