Support for the node_redis framework#73
Conversation
Merge trunk update
Merge main library code
| Tags.DB_TYPE.tag(span, "Redis"); | ||
| Tags.DB_INSTANCE.tag(span, connection.selected_db); | ||
| Tags.DB_STATEMENT.tag(span, command_obj.command); | ||
| contextManager.finishSpan(span); |
There was a problem hiding this comment.
Why do you finish span in this time? The cost time of Redis span is incorrect if you finish the span in this time. The cost of real Redis span is the cost of executing Redis command.
There was a problem hiding this comment.
Why do you finish span in this time? The cost time of Redis span is incorrect if you finish the span in this time. The cost of real Redis span is the cost of executing Redis command.
Hi @ascrutae , seems this comment is addressed, is there anything else that needs to be updated? Let me continue this if there is any
|
which node_module will this plugin support? |
|
|
using ioredis now |
ioredis is not supported in this time. |
|
my mistake, there is wrong reading for ioredis document. |
5 participants
No description provided.