Skip to content

Wardrobe Helper Options, and Optional third argument for config commands. #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Ashley-Cause
Copy link

No description provided.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Feb 19, 2025
@Ashley-Cause Ashley-Cause changed the title Optionally show keybind instead of number in Wardrobe Helper. Wardrobe Helper Options, and Optional third argument for config commands. Feb 19, 2025
@Ashley-Cause
Copy link
Author

Apologies for the many commits, still figuring out how git works.

Added an option to display the keybind to select a wardrobe slot, instead of the hotbar number, for anyone who (like me) doesn't have their hotbar slots bound only to number keys.

Added an optional third argument to the /skyblocker (config/option) commands, to open a specific category/tab in the config.
E.g. /Skyblocker config crimson opens the tag for the Crimson Isle location.

@kevinthegreat1
Copy link
Collaborator

Thanks for your pr. There seem to be two changes in here that should be split up. Since this pr is on your main branch, you should create two new branches, one for your wardrobe helper changes and one for your config command changes. You can use cherry pick to copy over the commits or you can manually make the changes. After that, you can open two new prs and close this one.

@kevinthegreat1
Copy link
Collaborator

Also, there's no need for the option to show keybinds. Just show keybinds by default.

For command suggestions, don't hardcode the tab title values. Also, don't match the tab title by text, get the translation key at least.

@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Apr 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts This PR has merge conflicts that need solving.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants