Skip to content

Fancy Dungeon Map #1239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

kevinthegreat1
Copy link
Collaborator

  • Render player heads in the dungeon map
  • Add map to the leap menu
  • More to come

Note: this screenshot is taken on a low gui scale

Fancy Dungeon Map

@kevinthegreat1 kevinthegreat1 added new feature This issue or PR is a new feature reviews needed This PR needs reviews labels Apr 3, 2025
@Fluboxer
Copy link
Contributor

Fluboxer commented Apr 3, 2025

Can I ask for a thing? Make it show arrow to where player is looking
iirc custom fancy maps often overlook that despite this. It may help tell where players are headed and it is a thing normal vanilla map can do

also it can (and probably should) be toggleable

@AC19970
Copy link
Contributor

AC19970 commented Apr 3, 2025

The game freezes when starting. The avatars won't be displayed if teammates are too far. Do I need to set the render distance and simulation distance higher?

@kevinthegreat1
Copy link
Collaborator Author

Fixed the lag spike when starting the dungeon and added a little direction indicator. The problem with players going too far is a little more complicated, and I will look into it later.

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Apr 3, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Apr 4, 2025
@layou233

This comment was marked as resolved.

* Add show self head option
* Only show map in leap overlay while clearing
* Add inventory key to close leap overlay
@kevinthegreat1
Copy link
Collaborator Author

Note to self: one more bug, the tracking gets messed up when a player dyes. The solution should be to limit matches to the previous 100 or something.

@kevinthegreat1
Copy link
Collaborator Author

Map<String, Table<Pair<UUID, String>, Long, MutableInt>> to sort by timestamp as well?

* keep only the past 100 player matches (5 seconds)
@kevinthegreat1
Copy link
Collaborator Author

All bugs should have been fixed.

This could benefit from a dfu. This currently resets dungeons config.

@AzureAaron
Copy link
Collaborator

All bugs should have been fixed.

This could benefit from a dfu. This currently resets dungeons config.

There is no point, I doubt many people would ever be turning off the leap overlay to begin with.

@kevinthegreat1
Copy link
Collaborator Author

There is no point, I doubt many people would ever be turning off the leap overlay to begin with.

The problem is this reset all dungeons config, unless we can think of a different name for the spiritLeapOverlay field.

@kevinthegreat1 kevinthegreat1 added the merge me please Pull requests that are ready to merge label Apr 15, 2025
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed merge me please Pull requests that are ready to merge reviews needed This PR needs reviews labels Apr 15, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Apr 16, 2025
@AzureAaron AzureAaron added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Apr 26, 2025
@layou233
Copy link

517fb25 hides all arrows on the map and breaks the intended purpose of "Show Self Head" option. 😢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge conflicts This PR has merge conflicts that need solving. new feature This issue or PR is a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants