Skip to content

Conversation

@7azeemm
Copy link
Contributor

@7azeemm 7azeemm commented Dec 12, 2025

Todo list:

  • Hide miniboss spawn message
  • Display alert for new personal best kill time
  • Make Command for showing slayers personal bests
  • Fix boss/miniboss spawn alert sound being too low
  • Add Option to show miniboss's name in spawn alert
  • Fix slayer quest detection not working in certain conditions
  • Select player's boss (if not detected due to it spawning far from player) or other people's boss on hit (won't select other bosses if player's boss is alive) (important for carries)
  • Fix Bossbar not being removed after boss kill
  • Make slayer timer ends when boss death detected instead of relying on slain msg in chat (use as fallback) (0.5s less)
  • Fix higher tier minibosses than boss tier being alerted (Slayer miniboss alerts for a higher slayer level shouldn't show #1915)
  • Highlight unclaimed slayer levels rewards
  • Replace slayers icons with their custom textures (the ones used in pv) in Slayer HUD
  • Cache slayers info (killing 1 boss will not be required for the HUD to work anymore)
  • Custom highlight color option
  • Fix Hitbox highlight color being always black
  • Spider Slayer
    • Fix new t5 minibosses highlighting
    • Mute Spider sounds (Spiders, Silverfishs, Bats, Skeletons Sounds)
    • Fix t5 second phase slayer detection
  • Enderman Slayer
    • Fix lazer timer not working correctly (it works now, but the accuracy of time depends on server tps)
    • Add timer to beacons
  • Blaze Slayer
    • Fix slayer detection after spliting
    • Hide Hellion Shield messages
    • Mute Blaze Sounds (Blazes, Lightning Bolts, Lava/Fire, Fireballs thrown by the slayer (Ghast sounds))
  • Wolf Slayer
    • Mute Wolf sounds
    • Hide Sven Pups nametags

Things to work on later:

  • Track time to spawn boss
  • Make fire pillar warning for only the player's boss
  • Kills/hr and Estimated time to lvl up in Slayer HUD
  • HUD for RNG meter xp, selected item, kills left, drop chance

Copilot AI review requested due to automatic review settings December 12, 2025 19:30
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Dec 12, 2025
@7azeemm 7azeemm marked this pull request as draft December 12, 2025 19:33
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. wip This PR is a work in progress and removed reviews needed This PR needs reviews labels Dec 12, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses various slayer-related fixes and features, with the primary focus on fixing the Enderman slayer laser timer functionality. The changes refactor the timer logic to use a cooldown-based activation system rather than tracking the riding state.

Key Changes:

  • Refactored Enderman laser timer with 10-second activation cooldown to prevent rapid re-triggering
  • Simplified timer tick logic and removed dependency on vehicle state tracking
  • Changed default behavior to mute enderman sounds in The End

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
LazerTimer.java Refactored timer from riding-state-based to activation-cooldown-based system with simplified tick logic and updated rendering
EntityMixin.java Simplified tick method logic and removed unused shadow methods (getVehicle()) and imports
OtherLocationsConfig.java Changed default value for muteEndermanSounds from false to true in The End configuration

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox added merge conflicts This PR has merge conflicts that need solving. and removed merge conflicts This PR has merge conflicts that need solving. labels Dec 13, 2025
@7azeemm 7azeemm force-pushed the Slayers branch 2 times, most recently from 7c8753f to 1952562 Compare December 13, 2025 13:40
@LifeIsAParadox LifeIsAParadox added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@LifeIsAParadox LifeIsAParadox removed the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
@Alex33856 Alex33856 added the merge conflicts This PR has merge conflicts that need solving. label Dec 13, 2025
# Conflicts:
#	src/main/java/de/hysky/skyblocker/config/categories/SlayersCategory.java
#	src/main/java/de/hysky/skyblocker/config/configs/SlayersConfig.java
#	src/main/java/de/hysky/skyblocker/mixins/BossBarHudMixin.java
#	src/main/java/de/hysky/skyblocker/mixins/ClientPlayNetworkHandlerMixin.java
#	src/main/java/de/hysky/skyblocker/mixins/ClientPlayerInteractionManagerMixin.java
#	src/main/java/de/hysky/skyblocker/mixins/EntityMixin.java
#	src/main/java/de/hysky/skyblocker/mixins/EntityRenderDispatcherMixin.java
#	src/main/java/de/hysky/skyblocker/mixins/EntityRendererMixin.java
#	src/main/java/de/hysky/skyblocker/skyblock/end/MuteEndermen.java
#	src/main/java/de/hysky/skyblocker/skyblock/entity/MobBoundingBoxes.java
#	src/main/java/de/hysky/skyblocker/skyblock/entity/glow/adder/SlayerGlowAdder.java
#	src/main/java/de/hysky/skyblocker/skyblock/profileviewer/slayers/SlayerWidget.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerBossBars.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerHudWidget.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerManager.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerTier.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerTimer.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerType.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/boss/demonlord/AttunementColors.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/boss/demonlord/FirePillarAnnouncer.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/boss/vampire/ManiaIndicator.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/boss/vampire/TwinClawsIndicator.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/boss/voidgloom/BeaconHighlighter.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/boss/voidgloom/LazerTimer.java
@7azeemm 7azeemm marked this pull request as ready for review December 20, 2025 12:56
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed wip This PR is a work in progress labels Dec 20, 2025
@Alex33856 Alex33856 added this to the 6.0.0 milestone Dec 20, 2025
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

review of the simpler stuff first. will review the bigger files at a later time

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes and removed reviews needed This PR needs reviews labels Dec 20, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed changes requested This PR need changes labels Dec 21, 2025
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews changes requested This PR need changes labels Dec 28, 2025
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Jan 2, 2026
# Conflicts:
#	src/main/java/de/hysky/skyblocker/config/categories/SlayersCategory.java
#	src/main/java/de/hysky/skyblocker/mixins/EntityRendererMixin.java
#	src/main/java/de/hysky/skyblocker/skyblock/slayers/SlayerManager.java
@7azeemm 7azeemm requested a review from viciscat January 2, 2026 14:05
@Alex33856 Alex33856 added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Jan 5, 2026
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving since all requested changes have been made. I can solve the conflicts if they are not solved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge conflicts This PR has merge conflicts that need solving.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants