Skip to content

Conversation

@olim88
Copy link
Contributor

@olim88 olim88 commented Dec 19, 2025

works out how long it is going to take to mine a block and animate this client side so there is no ping in the animation.

there is also an sound effect option.

suggested here: https://discord.com/channels/879732108745125969/1441061868939640982.

I will take any suggesting to get rid of LegacyLookup / combine this block list with with the pickaxe ability.

@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Dec 19, 2025
@olim88 olim88 added new feature This issue or PR is a new feature and removed reviews needed This PR needs reviews labels Dec 19, 2025
@olim88 olim88 force-pushed the client-side-mining-animations branch from 710fd5d to b213d95 Compare December 19, 2025 18:35
@LifeIsAParadox LifeIsAParadox added the reviews needed This PR needs reviews label Dec 19, 2025
@viciscat viciscat changed the title Client side mineing animations Client side mining animations Dec 19, 2025
Copy link
Collaborator

@viciscat viciscat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use a LOGGER instead of printStackTrace()

@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes reviews needed This PR needs reviews and removed reviews needed This PR needs reviews changes requested This PR need changes labels Dec 19, 2025
@LifeIsAParadox LifeIsAParadox added changes requested This PR need changes reviews needed This PR needs reviews and removed reviews needed This PR needs reviews changes requested This PR need changes labels Dec 19, 2025
@Alex33856 Alex33856 added this to the 6.0.0 milestone Dec 19, 2025
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds client-side block breaking animations for mining in Hypixel Skyblock. The feature predicts how long it will take to mine a block based on the player's mining speed stat and the block's properties, then animates the break progress locally to eliminate ping-related delays. An optional sound effect can play when the block should break.

Key changes:

  • Implements client-side mining animation prediction using mining speed from tab list and block strength data from NEU repo
  • Adds configuration options to enable/disable the feature and toggle sound effects
  • Integrates block strength data loading from NEU repository with legacy block ID mappings

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 14 comments.

Show a summary per file
File Description
src/main/resources/assets/skyblocker/lang/en_us.json Adds translation keys for configuration options and warning message
src/main/java/de/hysky/skyblocker/utils/NEURepoManager.java Adds tree() method to access NEU repository file trees
src/main/java/de/hysky/skyblocker/skyblock/dwarven/BlockBreakPrediction.java Core implementation: calculates break time, loads block data, handles legacy block mappings
src/main/java/de/hysky/skyblocker/mixins/LevelRendererMixin.java Injects custom block breaking progress into rendering pipeline
src/main/java/de/hysky/skyblocker/config/configs/MiningConfig.java Adds BlockBreakPrediction configuration class with enabled and playSound options
src/main/java/de/hysky/skyblocker/config/categories/MiningCategory.java Adds UI configuration options for block break prediction feature

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also copilot seemed to have two good comments, which I’ve left.

@Alex33856 Alex33856 added merge conflicts This PR has merge conflicts that need solving. and removed reviews needed This PR needs reviews labels Jan 6, 2026
@olim88 olim88 force-pushed the client-side-mining-animations branch from 0dc12d2 to f6b302b Compare January 6, 2026 20:59
@LifeIsAParadox LifeIsAParadox added reviews needed This PR needs reviews and removed merge conflicts This PR has merge conflicts that need solving. labels Jan 6, 2026
Copy link
Collaborator

@kevinthegreat1 kevinthegreat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally couldn't notice any difference when testing, but lgtm.

@LifeIsAParadox LifeIsAParadox added merge me please Pull requests that are ready to merge and removed reviews needed This PR needs reviews labels Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge me please Pull requests that are ready to merge new feature This issue or PR is a new feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants