Ability cooldown durability bar #1961
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LifeIsAParadox
added
merge conflicts
viciscat
force-pushed
the
ability-cooldown-durability-bar
branch
from
632c1d7 to
439a3a9
Compare
LifeIsAParadox
added
reviews needed
Also: - Changes custom durability to an OptionalDouble instead of a IntIntPair - Only run logic on items whose durability bar are rendered (previously ran on all other player and armorstand equipment slots)
viciscat
force-pushed
the
ability-cooldown-durability-bar
branch
from
439a3a9 to
44d8daa
Compare
Contributor
|
Wouldn't it make more sense to have the cooldown as an actual cooldown (i.e. ender pearls) rather than durability? |
Collaborator
Author
|
Depends on who you ask. I think no since you can still use the item to mine unlike shield, ender pearl and grapple that becomes useless while they are on cooldown |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #1941
Closes #1901
On top of the feature also: