Fix item protection triggering on non-owned items#2427
Open
legentpc wants to merge 2 commits into
Open
Conversation
Contributor
|
The code looks good. However, this also stops people from protecting items in their backpacks / echest/ chests. I feel like as the bug does not harm the user in any way it would be silly to make a regression to fix it. Maybe it should just exclude AH. or have an white list to fix this. |
Contributor
Author
|
I tried multiple approaches to fix this but couldn't get it working correctly. Closing for now. |
legentpc
force-pushed
the
fix-item-protect
branch
from
1349a0b to
7bf0f05
Compare
LifeIsAParadox
added
merge me please
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Item protection now only applies to items in the player's own inventory, and the hotbar handler is skipped when any screen is open.
Problem
The item protection keybind (
V) was incorrectly triggering on non-owned items (Auction House, Bazaar, NPC shops, etc.) and double-firing on the hotbar item when a container screen was open.Fixes GH-2424
Changelog Fixes